remove `#[rustc_inherit_overflow_checks]` from `is_multiple_of` #147551

folkertdev · 2025-10-10T10:57:44Z

Most likely this was just a result of copy-pasting. The attribute has no effect, because % always uses overflow checks.

r? @Amanieu
cc @RalfJung

Amanieu · 2025-10-10T11:02:38Z

@bors r+ rollup

bors · 2025-10-10T11:02:40Z

📌 Commit 5ab4e18 has been approved by Amanieu

It is now in the queue for this repository.

bors · 2025-10-10T11:03:50Z

⌛ Testing commit 5ab4e18 with merge 8312360...

…Amanieu remove `#[rustc_inherit_overflow_checks]` from `is_multiple_of` Most likely this was just a result of copy-pasting. The attribute has no effect, because `%` always uses overflow checks. r? `@Amanieu` cc `@RalfJung`

rust-log-analyzer · 2025-10-10T12:07:36Z

The job aarch64-gnu-debug failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)


  --- stderr
  clang: error: unsupported option '-print-multi-os-directory'
  clang: error: no input files
  config.status: error: in `/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-tools/aarch64-unknown-linux-gnu/release/build/libffi-sys-6562d98fd0e95724/out/libffi-build/aarch64-unknown-linux-gnu':
  config.status: error: Something went wrong bootstrapping makefile fragments
      for automatic dependency tracking.  If GNU make was not used, consider
      re-running the configure script with MAKE="gmake" (or whatever is
      necessary).  You can also try re-running configure with the
      '--disable-dependency-tracking' option to at least be able to build
      the package (albeit without support for automatic dependency tracking).
  See `config.log' for more details

  thread 'main' (98754) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/libffi-sys-3.3.2/build/not_msvc.rs:154:5:
  Configuring libffi: exit status: 1 (cd "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-tools/aarch64-unknown-linux-gnu/release/build/libffi-sys-6562d98fd0e95724/out/libffi-build" && CC="clang" CFLAGS="-O3 -ffunction-sections -fdata-sections -fPIC -gdwarf-4 -fno-omit-frame-pointer --target=aarch64-unknown-linux-gnu -Wno-implicit-function-declaration" LC_ALL="C" "sh" "./configure" "--with-pic" "--disable-shared" "--disable-docs" "--prefix" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-tools/aarch64-unknown-linux-gnu/release/build/libffi-sys-6562d98fd0e95724/out/libffi-root")
  stack backtrace:
     0: __rustc::rust_begin_unwind
               at /checkout/library/std/src/panicking.rs:698:5
     1: core::panicking::panic_fmt
               at /checkout/library/core/src/panicking.rs:80:14
     2: build_script_build::common::run_command
               at ./build/common.rs:13:13
     3: build_script_build::not_msvc::configure_libffi
               at ./build/not_msvc.rs:154:5
     4: build_script_build::not_msvc::build_and_link
               at ./build/not_msvc.rs:39:5
     5: build_script_build::main
               at ./build/build.rs:16:9
     6: core::ops::function::FnOnce::call_once
               at /checkout/library/core/src/ops/function.rs:250:5
  note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

bors · 2025-10-10T12:08:17Z

💔 Test failed - checks-actions

RalfJung · 2025-10-10T12:11:30Z

What the...?^^
I don't see how this can be spurious but it also can't be this PR.^^

@bors retry libffi build script: clang: error: unsupported option '-print-multi-os-directory'

Rollup of 12 pull requests Successful merges: - #145651 (Regression test for const promotion with Option<Ordering>) - #145722 (implement Extend<{Group, Literal, Punct, Ident}> for TokenStream) - #146520 (Promote armv8r-none-eabihf target to Tier 2) - #146522 (Promote armv7a-none-eabihf to Tier 2) - #147289 (Mitigate `thread_local!` shadowing issues) - #147515 (Update rustc-perf submodule) - #147522 (compiletest: Use the same directive lines for EarlyProps and ignore/only/needs) - #147525 (Replace locals in debuginfo records during ref_prop and dest_prop) - #147544 (Remove StatementKind::Deinit.) - #147551 (remove `#[rustc_inherit_overflow_checks]` from `is_multiple_of`) - #147553 (Move `wasm32-wasip3` to the tier 3 table) - #147562 (Stabilize `NonZero<u*>::div_ceil`) r? `@ghost` `@rustbot` modify labels: rollup

RalfJung · 2025-10-11T12:37:14Z

@bors treeclosed-

Rollup of 12 pull requests Successful merges: - #145651 (Regression test for const promotion with Option<Ordering>) - #145722 (implement Extend<{Group, Literal, Punct, Ident}> for TokenStream) - #146520 (Promote armv8r-none-eabihf target to Tier 2) - #146522 (Promote armv7a-none-eabihf to Tier 2) - #147289 (Mitigate `thread_local!` shadowing issues) - #147515 (Update rustc-perf submodule) - #147522 (compiletest: Use the same directive lines for EarlyProps and ignore/only/needs) - #147525 (Replace locals in debuginfo records during ref_prop and dest_prop) - #147544 (Remove StatementKind::Deinit.) - #147551 (remove `#[rustc_inherit_overflow_checks]` from `is_multiple_of`) - #147553 (Move `wasm32-wasip3` to the tier 3 table) - #147562 (Stabilize `NonZero<u*>::div_ceil`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #147551 - folkertdev:is-multiple-of-overflow-checks, r=Amanieu remove `#[rustc_inherit_overflow_checks]` from `is_multiple_of` Most likely this was just a result of copy-pasting. The attribute has no effect, because `%` always uses overflow checks. r? `@Amanieu` cc `@RalfJung`

Rollup of 12 pull requests Successful merges: - rust-lang/rust#145651 (Regression test for const promotion with Option<Ordering>) - rust-lang/rust#145722 (implement Extend<{Group, Literal, Punct, Ident}> for TokenStream) - rust-lang/rust#146520 (Promote armv8r-none-eabihf target to Tier 2) - rust-lang/rust#146522 (Promote armv7a-none-eabihf to Tier 2) - rust-lang/rust#147289 (Mitigate `thread_local!` shadowing issues) - rust-lang/rust#147515 (Update rustc-perf submodule) - rust-lang/rust#147522 (compiletest: Use the same directive lines for EarlyProps and ignore/only/needs) - rust-lang/rust#147525 (Replace locals in debuginfo records during ref_prop and dest_prop) - rust-lang/rust#147544 (Remove StatementKind::Deinit.) - rust-lang/rust#147551 (remove `#[rustc_inherit_overflow_checks]` from `is_multiple_of`) - rust-lang/rust#147553 (Move `wasm32-wasip3` to the tier 3 table) - rust-lang/rust#147562 (Stabilize `NonZero<u*>::div_ceil`) r? `@ghost` `@rustbot` modify labels: rollup

remove #[rustc_inherit_overflow_checks] from is_multiple_of

5ab4e18

rustbot assigned Amanieu Oct 10, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 10, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 10, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2025

RalfJung mentioned this pull request Oct 10, 2025

libffi build error on aarch64-gnu-debug: unsupported option '-print-multi-os-directory' #147556

Open

dianqk mentioned this pull request Oct 10, 2025

Rollup of 12 pull requests #147574

Merged

bors merged commit 38a5143 into rust-lang:master Oct 11, 2025
10 of 11 checks passed

rustbot added this to the 1.92.0 milestone Oct 11, 2025

github-actions bot mentioned this pull request Oct 21, 2025

Toolchain upgrade to nightly-2025-10-21 flux-rs/flux#1345

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

remove `#[rustc_inherit_overflow_checks]` from `is_multiple_of` #147551

remove `#[rustc_inherit_overflow_checks]` from `is_multiple_of` #147551

Uh oh!

folkertdev commented Oct 10, 2025

Uh oh!

Amanieu commented Oct 10, 2025

Uh oh!

bors commented Oct 10, 2025

Uh oh!

bors commented Oct 10, 2025

Uh oh!

rust-log-analyzer commented Oct 10, 2025

Uh oh!

bors commented Oct 10, 2025

Uh oh!

RalfJung commented Oct 10, 2025

Uh oh!

RalfJung commented Oct 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

remove #[rustc_inherit_overflow_checks] from is_multiple_of #147551

remove #[rustc_inherit_overflow_checks] from is_multiple_of #147551

Uh oh!

Conversation

folkertdev commented Oct 10, 2025

Uh oh!

Amanieu commented Oct 10, 2025

Uh oh!

bors commented Oct 10, 2025

Uh oh!

bors commented Oct 10, 2025

Uh oh!

rust-log-analyzer commented Oct 10, 2025

Uh oh!

bors commented Oct 10, 2025

Uh oh!

RalfJung commented Oct 10, 2025

Uh oh!

RalfJung commented Oct 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

remove `#[rustc_inherit_overflow_checks]` from `is_multiple_of` #147551

remove `#[rustc_inherit_overflow_checks]` from `is_multiple_of` #147551