Skip to content

Comments

Avoid suggesting constrain the associated type with unknown type#147362

Merged
bors merged 1 commit intorust-lang:mainfrom
chenyukang:yukang-fix-bound-147356
Nov 29, 2025
Merged

Avoid suggesting constrain the associated type with unknown type#147362
bors merged 1 commit intorust-lang:mainfrom
chenyukang:yukang-fix-bound-147356

Conversation

@chenyukang
Copy link
Member

@chenyukang chenyukang commented Oct 5, 2025 •
edited by rustbot
Loading

Fixes #147356

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 5, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 5, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

A4-Tacks
A4-Tacks reviewed Oct 5, 2025
View reviewed changes
@chenyukang chenyukang marked this pull request as draft October 5, 2025 11:10
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2025
@chenyukang chenyukang force-pushed the yukang-fix-bound-147356 branch from d9c0b23 to e94fab3 Compare October 5, 2025 12:01
@chenyukang chenyukang marked this pull request as ready for review October 5, 2025 12:03
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 5, 2025
fee1-dead
fee1-dead requested changes Oct 17, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2025
@fee1-dead
Copy link
Member

fee1-dead commented Oct 17, 2025

cc @petrochenkov who knows more about LateResolutionVisitor

@chenyukang chenyukang force-pushed the yukang-fix-bound-147356 branch from e94fab3 to baeee34 Compare November 22, 2025 02:18
@rustbot
Copy link
Collaborator

rustbot commented Nov 22, 2025

⚠️ Warning ⚠️

@chenyukang chenyukang changed the title Avoid suggesting constrain the associated type to a trait Avoid suggesting constrain the associated type to a ident with unknown type Nov 22, 2025
@chenyukang chenyukang changed the title Avoid suggesting constrain the associated type to a ident with unknown type Avoid suggesting constrain the associated type with unknown type Nov 22, 2025
@chenyukang chenyukang force-pushed the yukang-fix-bound-147356 branch from baeee34 to 76bd555 Compare November 22, 2025 02:21
@chenyukang
Copy link
Member Author

chenyukang commented Nov 22, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 22, 2025
@fee1-dead
Copy link
Member

fee1-dead commented Nov 28, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 28, 2025

📌 Commit 76bd555 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2025
@jhpratt jhpratt mentioned this pull request Nov 29, 2025
Merged
bors added a commit that referenced this pull request Nov 29, 2025
@bors
Auto merge of #149441 - jhpratt:rollup-4hmqc0z, r=jhpratt
3c5c558 
Rollup of 5 pull requests

Successful merges:

 - #147362 (Avoid suggesting constrain the associated type with unknown type)
 - #149395 (float::minimum/maximum: say which exact IEEE operation this corresponds to)
 - #149396 (Remove outdated comment)
 - #149421 (Add a regression test for issue 129865)
 - #149424 (Update books)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 888e5da into rust-lang:main Nov 29, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 29, 2025
rust-timer added a commit that referenced this pull request Nov 29, 2025
@rust-timer
Unrolled build for #147362
0dbcf7d 
Rollup merge of #147362 - chenyukang:yukang-fix-bound-147356, r=fee1-dead

Avoid suggesting constrain the associated type with unknown type

Fixes #147356
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jan 20, 2026
@bors
Auto merge of rust-lang#149441 - jhpratt:rollup-4hmqc0z, r=jhpratt
b5dacca 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#147362 (Avoid suggesting constrain the associated type with unknown type)
 - rust-lang#149395 (float::minimum/maximum: say which exact IEEE operation this corresponds to)
 - rust-lang#149396 (Remove outdated comment)
 - rust-lang#149421 (Add a regression test for issue 129865)
 - rust-lang#149424 (Update books)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@A4-Tacks A4-Tacks A4-Tacks left review comments

@fee1-dead fee1-dead fee1-dead requested changes

Assignees

@fee1-dead fee1-dead

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

False positive in bound for is not a trait

5 participants

@chenyukang @rustbot @fee1-dead @bors @A4-Tacks