- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
Fix wrong span for hightlight for duplicated diff lines #147354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            bors
  merged 1 commit into
  rust-lang:master
from
chenyukang:yukang-fix-147070-wrong-highlight-span
  
      
      
   
  Oct 7, 2025 
      
    
      
        
          +103
        
        
          −1
        
        
          
        
      
    
  
  
     Merged
                    Changes from all commits
      Commits
    
    
  File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
        
          
          
            30 changes: 30 additions & 0 deletions
          
          30 
        
  tests/ui/argument-suggestions/wrong-highlight-span-extra-arguments-147070.rs
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| //@ only-linux | ||
| //@ compile-flags: --error-format=human --color=always | ||
|  | ||
| // The hightlight span should be correct. See #147070 | ||
| struct Thingie; | ||
|  | ||
| impl Thingie { | ||
| pub(crate) fn new( | ||
| _a: String, | ||
| _b: String, | ||
| _c: String, | ||
| _d: String, | ||
| _e: String, | ||
| _f: String, | ||
| ) -> Self { | ||
| unimplemented!() | ||
| } | ||
| } | ||
|  | ||
| fn main() { | ||
| let foo = Thingie::new( | ||
| String::from(""), | ||
| String::from(""), | ||
| String::from(""), | ||
| String::from(""), | ||
| String::from(""), | ||
| String::from(""), | ||
| String::from(""), | ||
| ); | ||
| } | ||
        
          
          
            72 changes: 72 additions & 0 deletions
          
          72 
        
  tests/ui/argument-suggestions/wrong-highlight-span-extra-arguments-147070.svg
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.