Skip to content

Explicity disable LSX feature for loongarch64-unknown-none target #146032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

Explicity disable LSX feature for loongarch64-unknown-none target #146032

merged 1 commit into from
Sep 3, 2025

Conversation

@heiher
Copy link
Contributor

@heiher heiher commented Aug 30, 2025

The loongarch64-unknown-none target is a bare-metal target with hardware floating-point support and should not enable SIMD extensions by default. However, LLVM's LoongArch64 backend enables LSX implicitly, inadvertently activating SIMD instructions for this target. This patch explicitly disable LSX feature to prevent unintended SIMD usage.

@heiher
Explicity disable LSX feature for loongarch64-unknown-none target
0b1bc65 
The `loongarch64-unknown-none` target is a bare-metal target with
hardware floating-point support and should not enable SIMD extensions
by default. However, LLVM's LoongArch64 backend enables LSX implicitly,
inadvertently activating SIMD instructions for this target. This patch
explicitly disable LSX feature to prevent unintended SIMD usage.
@rustbot
Copy link
Collaborator

rustbot commented Aug 30, 2025

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 30, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

@lqd
Copy link
Member

lqd commented Sep 2, 2025

Thanks!

r? lqd @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 2, 2025

📌 Commit 0b1bc65 has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2025
@jackh726
Copy link
Member

jackh726 commented Sep 2, 2025

I wanted to ask

bare-metal target with hardware floating-point support and should not enable SIMD extensions by default

why is this?

@lqd
Copy link
Member

lqd commented Sep 2, 2025 •
edited
Loading

It should be like x86, they are extensions that are not necessarily supported by the cpu baseline defined by the target.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 2, 2025
@GuillaumeGomez
Rollup merge of rust-lang#146032 - heiher:loong64-none-no-lsx, r=lqd
e8ca9d6 
Explicity disable LSX feature for `loongarch64-unknown-none` target

The `loongarch64-unknown-none` target is a bare-metal target with hardware floating-point support and should not enable SIMD extensions by default. However, LLVM's LoongArch64 backend enables LSX implicitly, inadvertently activating SIMD instructions for this target. This patch explicitly disable LSX feature to prevent unintended SIMD usage.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 2, 2025
@GuillaumeGomez
Rollup merge of rust-lang#146032 - heiher:loong64-none-no-lsx, r=lqd
4fec477 
Explicity disable LSX feature for `loongarch64-unknown-none` target

The `loongarch64-unknown-none` target is a bare-metal target with hardware floating-point support and should not enable SIMD extensions by default. However, LLVM's LoongArch64 backend enables LSX implicitly, inadvertently activating SIMD instructions for this target. This patch explicitly disable LSX feature to prevent unintended SIMD usage.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 2, 2025
Closed
bors added a commit that referenced this pull request Sep 2, 2025
@bors
Auto merge of #146139 - GuillaumeGomez:rollup-urehddd, r=GuillaumeGomez
05d62d3 
Rollup of 8 pull requests

Successful merges:

 - #139113 (unstable book: in a sanitizer example, check the code)
 - #145823 (editorconfig: don't use nonexistent syntax)
 - #145962 (Ensure we emit an allocator shim when only some crate types need one)
 - #146032 (Explicity disable LSX feature for `loongarch64-unknown-none` target)
 - #146090 (Derive `PartialEq` for `InvisibleOrigin`)
 - #146120 (Correct typo in `rustc_errors` comment)
 - #146121 (fix: Filter suggestion parts that match existing code)
 - #146134 (llvm: nvptx: Layout update to match LLVM)

r? `@ghost`
`@rustbot` modify labels: rollup
tgross35 added a commit to tgross35/rust that referenced this pull request Sep 3, 2025
@tgross35
Rollup merge of rust-lang#146032 - heiher:loong64-none-no-lsx, r=lqd
24458ac 
Explicity disable LSX feature for `loongarch64-unknown-none` target

The `loongarch64-unknown-none` target is a bare-metal target with hardware floating-point support and should not enable SIMD extensions by default. However, LLVM's LoongArch64 backend enables LSX implicitly, inadvertently activating SIMD instructions for this target. This patch explicitly disable LSX feature to prevent unintended SIMD usage.
@tgross35 tgross35 mentioned this pull request Sep 3, 2025
Closed
bors added a commit that referenced this pull request Sep 3, 2025
@bors
Auto merge of #146141 - tgross35:rollup-vx6hx6n, r=tgross35
08780cf 
Rollup of 8 pull requests

Successful merges:

 - #139113 (unstable book: in a sanitizer example, check the code)
 - #145279 (Constify conversion traits (part 1))
 - #145414 (unicode-table-generator refactors)
 - #145823 (editorconfig: don't use nonexistent syntax)
 - #145944 (std: Start supporting WASIp2 natively )
 - #145961 (resolve: Avoid a regression from splitting prelude into two scopes)
 - #146032 (Explicity disable LSX feature for `loongarch64-unknown-none` target)
 - #146106 (fix(lexer): Only allow horizontal whitespace in frontmatter )

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Sep 3, 2025
@bors
Auto merge of #146141 - tgross35:rollup-vx6hx6n, r=tgross35
6267c26 
Rollup of 8 pull requests

Successful merges:

 - #139113 (unstable book: in a sanitizer example, check the code)
 - #145279 (Constify conversion traits (part 1))
 - #145414 (unicode-table-generator refactors)
 - #145823 (editorconfig: don't use nonexistent syntax)
 - #145944 (std: Start supporting WASIp2 natively )
 - #145961 (resolve: Avoid a regression from splitting prelude into two scopes)
 - #146032 (Explicity disable LSX feature for `loongarch64-unknown-none` target)
 - #146106 (fix(lexer): Only allow horizontal whitespace in frontmatter )

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 3, 2025
@Zalathar
Rollup merge of rust-lang#146032 - heiher:loong64-none-no-lsx, r=lqd
24d59e3 
Explicity disable LSX feature for `loongarch64-unknown-none` target

The `loongarch64-unknown-none` target is a bare-metal target with hardware floating-point support and should not enable SIMD extensions by default. However, LLVM's LoongArch64 backend enables LSX implicitly, inadvertently activating SIMD instructions for this target. This patch explicitly disable LSX feature to prevent unintended SIMD usage.
@Zalathar Zalathar mentioned this pull request Sep 3, 2025
Closed
bors added a commit that referenced this pull request Sep 3, 2025
@bors
Auto merge of #146157 - Zalathar:rollup-0w8r7g6, r=Zalathar
0cae2f9 
Rollup of 9 pull requests

Successful merges:

 - #145279 (Constify conversion traits (part 1))
 - #145414 (unicode-table-generator refactors)
 - #145823 (editorconfig: don't use nonexistent syntax)
 - #145944 (std: Start supporting WASIp2 natively )
 - #145961 (resolve: Avoid a regression from splitting prelude into two scopes)
 - #146032 (Explicity disable LSX feature for `loongarch64-unknown-none` target)
 - #146106 (fix(lexer): Only allow horizontal whitespace in frontmatter )
 - #146112 (don't uppercase error messages)
 - #146154 (CI: rfl: move job forward to Linux v6.17-rc3 plus 2 commits)

r? `@ghost`
`@rustbot` modify labels: rollup
@Zalathar Zalathar mentioned this pull request Sep 3, 2025
Merged
bors added a commit that referenced this pull request Sep 3, 2025
@bors
Auto merge of #146160 - Zalathar:rollup-qxphx7g, r=Zalathar
fd75a9c 
Rollup of 8 pull requests

Successful merges:

 - #145279 (Constify conversion traits (part 1))
 - #145414 (unicode-table-generator refactors)
 - #145823 (editorconfig: don't use nonexistent syntax)
 - #145944 (std: Start supporting WASIp2 natively )
 - #145961 (resolve: Avoid a regression from splitting prelude into two scopes)
 - #146032 (Explicity disable LSX feature for `loongarch64-unknown-none` target)
 - #146106 (fix(lexer): Only allow horizontal whitespace in frontmatter )
 - #146154 (CI: rfl: move job forward to Linux v6.17-rc3 plus 2 commits)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1ec369e into rust-lang:master Sep 3, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 3, 2025
rust-timer added a commit that referenced this pull request Sep 3, 2025
@rust-timer
Unrolled build for #146032
e50460b 
Rollup merge of #146032 - heiher:loong64-none-no-lsx, r=lqd

Explicity disable LSX feature for `loongarch64-unknown-none` target

The `loongarch64-unknown-none` target is a bare-metal target with hardware floating-point support and should not enable SIMD extensions by default. However, LLVM's LoongArch64 backend enables LSX implicitly, inadvertently activating SIMD instructions for this target. This patch explicitly disable LSX feature to prevent unintended SIMD usage.
@heiher heiher deleted the loong64-none-no-lsx branch September 5, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lqd lqd

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

5 participants

@heiher @rustbot @lqd @bors @jackh726