Skip to content

Conversation

@GrigorenkoPV
Copy link
Contributor

@GrigorenkoPV GrigorenkoPV commented Aug 20, 2025

Closes #144707

r? t-libs-api

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 20, 2025
@tgross35
Copy link
Contributor

tgross35 commented Sep 3, 2025

@rustbot label +I-libs-api-nominated

@rustbot rustbot added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Sep 3, 2025
@Amanieu Amanieu added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed I-libs-api-nominated Nominated for discussion during a libs-api team meeting. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 23, 2025
@Amanieu
Copy link
Member

Amanieu commented Sep 23, 2025

@rfcbot merge

@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Sep 23, 2025

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rust-rfcbot rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Sep 23, 2025
@rust-rfcbot rust-rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Oct 15, 2025
@rust-rfcbot
Copy link
Collaborator

🔔 This is now entering its final comment period, as per the review above. 🔔

@rustbot
Copy link
Collaborator

rustbot commented Oct 21, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-rfcbot rust-rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Oct 25, 2025
@rust-rfcbot
Copy link
Collaborator

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@tgross35
Copy link
Contributor

r? tgross35
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 25, 2025

📌 Commit 144707a has been approved by tgross35

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 25, 2025
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 25, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 26, 2025
Don't require `T: RefUnwindSafe` for `vec::IntoIter<T>: UnwindSafe`

Closes rust-lang#144707

r? t-libs-api
bors added a commit that referenced this pull request Oct 26, 2025
Rollup of 3 pull requests

Successful merges:

 - #144090 (Make `IoSlice` and `IoSliceMut` methods unstably const)
 - #145665 (Don't require `T: RefUnwindSafe` for `vec::IntoIter<T>: UnwindSafe`)
 - #147818 (Unify and deduplicate max recip float tests)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 26, 2025
Don't require `T: RefUnwindSafe` for `vec::IntoIter<T>: UnwindSafe`

Closes rust-lang#144707

r? t-libs-api
bors added a commit that referenced this pull request Oct 26, 2025
Rollup of 4 pull requests

Successful merges:

 - #145665 (Don't require `T: RefUnwindSafe` for `vec::IntoIter<T>: UnwindSafe`)
 - #147728 (tests: activate misspelled `gdb-check` in `function-arg-initialization.rs`)
 - #148097 (tests/debuginfo/closures.rs: Activate misspelled `cdb-check`)
 - #148118 (Improve the ICE message for invalid nullary intrinsic calls)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Oct 26, 2025

⌛ Testing commit 144707a with merge a8664a1...

@bors
Copy link
Collaborator

bors commented Oct 26, 2025

☀️ Test successful - checks-actions
Approved by: tgross35
Pushing a8664a1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 26, 2025
@bors bors merged commit a8664a1 into rust-lang:master Oct 26, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Oct 26, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e517798 (parent) -> a8664a1 (this PR)

Test differences

Show 22 test diffs

22 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard a8664a1534913ccff491937ec2dc7ec5d973c2bd --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 11071.4s -> 7381.3s (-33.3%)
  2. dist-aarch64-apple: 7138.3s -> 6001.0s (-15.9%)
  3. tidy: 201.4s -> 171.6s (-14.8%)
  4. dist-aarch64-windows-gnullvm: 4523.0s -> 5019.2s (11.0%)
  5. dist-ohos-armv7: 3816.2s -> 4198.4s (10.0%)
  6. dist-x86_64-windows-gnullvm: 4718.3s -> 5151.0s (9.2%)
  7. dist-aarch64-msvc: 6072.3s -> 5516.8s (-9.1%)
  8. dist-s390x-linux: 5002.8s -> 5434.5s (8.6%)
  9. dist-loongarch64-musl: 5067.4s -> 5503.8s (8.6%)
  10. dist-powerpc-linux: 4938.8s -> 5362.3s (8.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a8664a1): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.1% [0.1%, 0.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.2% [2.2%, 2.2%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.2% [2.2%, 2.2%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.08s -> 474.827s (-0.05%)
Artifact size: 390.51 MiB -> 390.49 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vec::IntoIter<T>: UnwindSafe should not require T: RefUnwindSafe

8 participants