dedup recip, powi, to_degrees, and to_radians float tests #145468

karolzwolak · 2025-08-15T17:41:20Z

Deduplicates recip, powi, to_degrees, and to_radians float tests.
I had to fiddle and slightly increase the tolerances for a few comparisons, so maybe not all of the tests are worth deduplicating.

Part of #141726.
Best reviewed commit-by-commit.

r? @tgross35

library/coretests/tests/floats/mod.rs

karolzwolak · 2025-08-19T19:02:09Z

update: simplify and minimize thresholds for assert_approx_ex comparisons.

karolzwolak · 2025-08-19T19:55:44Z

update:

increase f16 APPROX theshold to 2e-3
use more precise values in tests to fix failures in CI

tgross35

One small request then LGTM

View changes since this review

library/coretests/tests/floats/mod.rs

I left the additional asserts on {f16, f128}::MAX.recip() in a new test_max_recip tests.

karolzwolak · 2025-08-30T13:02:43Z

@rustbot ready

tgross35 · 2025-08-30T19:46:52Z

Thank you!

@bors r+ rollup

bors · 2025-08-30T19:46:55Z

📌 Commit ddb15c2 has been approved by tgross35

It is now in the queue for this repository.

dedup recip, powi, to_degrees, and to_radians float tests Deduplicates recip, powi, to_degrees, and to_radians float tests. I had to fiddle and slightly increase the tolerances for a few comparisons, so maybe not all of the tests are worth deduplicating. Part of #141726. Best reviewed commit-by-commit. r? `@tgross35`

bors · 2025-08-30T22:12:08Z

⌛ Testing commit ddb15c2 with merge 87955a2...

tgross35 · 2025-08-31T12:15:59Z

Makes sense, let's double check. r=me after a pass
@bors2 try jobs=x86_64-gnu-aux

dedup recip, powi, to_degrees, and to_radians float tests try-job: x86_64-gnu-aux

rust-bors · 2025-08-31T13:44:41Z

💔 Test for eee819c failed: CI. Failed jobs:

try - x86_64-gnu-aux (web logs, extended logs)

karolzwolak · 2025-08-31T16:31:55Z

I also missed the

rust/library/coretests/tests/floats/f32.rs

Lines 12 to 15 in 564ee21

    
           /// Miri adds some extra errors to float functions; make sure the tests still pass. 
        
           /// These values are purely used as a canary to test against and are thus not a stable guarantee Rust provides. 
        
           /// They serve as a way to get an idea of the real precision of floating point operations on different platforms. 
        
           const APPROX_DELTA: f32 = if cfg!(miri) { 1e-4 } else { 1e-6 };

in

rust/library/coretests/tests/floats/f32.rs

Line 55 in 564ee21

assert_approx_eq!((-3.1f32).powi(2), 9.61, APPROX_DELTA);

@tgross35 Could you re-run the try job? I don't have the privileges.

tgross35 · 2025-08-31T18:41:58Z

@bors2 try jobs=x86_64-gnu-aux

dedup recip, powi, to_degrees, and to_radians float tests try-job: x86_64-gnu-aux

rust-bors · 2025-08-31T20:34:24Z

☀️ Try build successful (CI)
Build commit: 4539ffa (4539ffa0b42be19574e5181628bbbc3e00adcd65, parent: 564ee219127b796d56f74767366fd359758b97de)

tgross35 · 2025-08-31T20:48:26Z

Going to run once more because I think the earlier failures came from Miri's randomness
@bors2 try jobs=x86_64-gnu-aux

dedup recip, powi, to_degrees, and to_radians float tests try-job: x86_64-gnu-aux

rust-bors · 2025-08-31T22:44:57Z

☀️ Try build successful (CI)
Build commit: 878adfd (878adfdad5d4813464596c61503f5817e19d8eb2, parent: f73bcd50a433b7c17225ca98b44064236e7e84b3)

tgross35 · 2025-09-01T07:01:26Z

@bors r+

bors · 2025-09-01T07:01:29Z

📌 Commit 9028efc has been approved by tgross35

It is now in the queue for this repository.

Rollup of 5 pull requests Successful merges: - #145468 (dedup recip, powi, to_degrees, and to_radians float tests) - #145643 (coverage: Build an "expansion tree" and use it to unexpand raw spans) - #145754 (fix(lexer): Don't require frontmatters to be escaped with indented fences) - #146060 (fixup nix dev shell again) - #146068 (compiletest: Capture panic messages via a custom panic hook) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #145468 - karolzwolak:float-tests-dedup, r=tgross35 dedup recip, powi, to_degrees, and to_radians float tests Deduplicates recip, powi, to_degrees, and to_radians float tests. I had to fiddle and slightly increase the tolerances for a few comparisons, so maybe not all of the tests are worth deduplicating. Part of #141726. Best reviewed commit-by-commit. r? `@tgross35`

…gross35 dedup recip, powi, to_degrees, and to_radians float tests Deduplicates recip, powi, to_degrees, and to_radians float tests. I had to fiddle and slightly increase the tolerances for a few comparisons, so maybe not all of the tests are worth deduplicating. Part of rust-lang#141726. Best reviewed commit-by-commit. r? `@tgross35`

Rollup of 5 pull requests Successful merges: - rust-lang#145468 (dedup recip, powi, to_degrees, and to_radians float tests) - rust-lang#145643 (coverage: Build an "expansion tree" and use it to unexpand raw spans) - rust-lang#145754 (fix(lexer): Don't require frontmatters to be escaped with indented fences) - rust-lang#146060 (fixup nix dev shell again) - rust-lang#146068 (compiletest: Capture panic messages via a custom panic hook) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned tgross35 Aug 15, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 15, 2025

karolzwolak force-pushed the float-tests-dedup branch from b720664 to e5fed16 Compare August 15, 2025 17:46

tgross35 requested changes Aug 19, 2025

View reviewed changes

library/coretests/tests/floats/mod.rs Outdated Show resolved Hide resolved

library/coretests/tests/floats/mod.rs Outdated Show resolved Hide resolved

library/coretests/tests/floats/mod.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2025

karolzwolak force-pushed the float-tests-dedup branch from e5fed16 to 43b54cd Compare August 19, 2025 18:59

This comment has been minimized.

Sign in to view

karolzwolak force-pushed the float-tests-dedup branch from 43b54cd to 75c9ee4 Compare August 19, 2025 19:54

karolzwolak requested a review from tgross35 August 20, 2025 17:41

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 20, 2025

tgross35 requested changes Aug 28, 2025

View reviewed changes

library/coretests/tests/floats/mod.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2025

dedup recip float test

6ebd009

I left the additional asserts on {f16, f128}::MAX.recip() in a new test_max_recip tests.

karolzwolak force-pushed the float-tests-dedup branch from 75c9ee4 to ddb15c2 Compare August 30, 2025 13:01

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 30, 2025

tgross35 approved these changes Aug 30, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2025

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Aug 31, 2025

Auto merge of #145468 - karolzwolak:float-tests-dedup, r=<try>

eee819c

dedup recip, powi, to_degrees, and to_radians float tests try-job: x86_64-gnu-aux

This comment has been minimized.

Sign in to view

karolzwolak added 3 commits August 31, 2025 18:16

dedup powi float test

e10e6d7

dedup to_degrees float test

c81a8a8

dedup to_radians float test

9028efc

karolzwolak force-pushed the float-tests-dedup branch from 8082354 to 9028efc Compare August 31, 2025 16:24

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Aug 31, 2025

Auto merge of #145468 - karolzwolak:float-tests-dedup, r=<try>

4539ffa

dedup recip, powi, to_degrees, and to_radians float tests try-job: x86_64-gnu-aux

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Aug 31, 2025

Auto merge of #145468 - karolzwolak:float-tests-dedup, r=<try>

878adfd

dedup recip, powi, to_degrees, and to_radians float tests try-job: x86_64-gnu-aux

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2025

Zalathar mentioned this pull request Sep 1, 2025

Rollup of 5 pull requests #146077

Merged

bors merged commit 1d520e2 into rust-lang:master Sep 1, 2025
11 checks passed

rustbot added this to the 1.91.0 milestone Sep 1, 2025

github-actions bot mentioned this pull request Sep 5, 2025

Toolchain upgrade to nightly-2025-09-09 flux-rs/flux#1260

Merged

dedup recip, powi, to_degrees, and to_radians float tests #145468

dedup recip, powi, to_degrees, and to_radians float tests #145468

Uh oh!

Conversation

karolzwolak commented Aug 15, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

karolzwolak commented Aug 19, 2025

Uh oh!

This comment has been minimized.

karolzwolak commented Aug 19, 2025

Uh oh!

tgross35 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

karolzwolak commented Aug 30, 2025

Uh oh!

tgross35 commented Aug 30, 2025

Uh oh!

bors commented Aug 30, 2025

Uh oh!

bors commented Aug 30, 2025

Uh oh!

tgross35 commented Aug 31, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Aug 31, 2025

Uh oh!

karolzwolak commented Aug 31, 2025

Uh oh!

tgross35 commented Aug 31, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Aug 31, 2025

Uh oh!

tgross35 commented Aug 31, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Aug 31, 2025

Uh oh!

tgross35 commented Sep 1, 2025

Uh oh!

bors commented Sep 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

karolzwolak commented Aug 15, 2025 •

edited by rustbot

Loading

tgross35 left a comment •

edited by rustbot

Loading