Skip to content

compiletest: Require explicit --filecheck-prefixes #145428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

compiletest: Require explicit --filecheck-prefixes #145428

wants to merge 1 commit into from
+244 −42

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Aug 15, 2025 •
edited
Loading

Fixes: #134510

r? @ghost

try-job: aarch64-apple
try-job: i686-gnu-*
try-job: test-various
try-job: x86_64-msvc-1
try-job: x86_64-msvc-2

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2025

Some changes occurred in src/tools/compiletest

cc @jieyouxu

Some changes occurred in tests/codegen-llvm/sanitizer

cc @rcvalle

@tgross35 tgross35 marked this pull request as draft August 15, 2025 09:10
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2025
@tgross35 tgross35 added the rla-silenced Silences rust-log-analyzer postings to the PR it's added on. label Aug 15, 2025
@tgross35 tgross35 force-pushed the less-filecheck-magic branch 2 times, most recently from 59c64d4 to 11ae4d5 Compare August 15, 2025 20:55
@tgross35 tgross35 force-pushed the less-filecheck-magic branch from 11ae4d5 to 3fa9db2 Compare August 15, 2025 21:47
@tgross35
Copy link
Contributor Author

@bors2 try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Aug 15, 2025
@rust-bors
Auto merge of #145428 - tgross35:less-filecheck-magic, r=<try>
37206fb 
compiletest: Require explicit `--filecheck-prefixes`

try-job: aarch64-apple
try-job: i686-gnu-*
try-job: test-various
try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@rust-log-analyzer
Copy link
Collaborator

The job test-various failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
failures:

---- [codegen] tests/codegen-llvm/codemodels.rs#MODEL-KERNEL stdout ----

error in revision `MODEL-KERNEL`: verification with 'FileCheck' failed
status: exit status: 2
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen-llvm/codemodels.MODEL-KERNEL/codemodels.ll" "/checkout/tests/codegen-llvm/codemodels.rs" "--dump-input-context" "100"
stdout: none
--- stderr -------------------------------
error: no check strings found with prefix 'CHECK:'
------------------------------------------


---- [codegen] tests/codegen-llvm/codemodels.rs#MODEL-LARGE stdout ----

error in revision `MODEL-LARGE`: verification with 'FileCheck' failed
status: exit status: 2
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen-llvm/codemodels.MODEL-LARGE/codemodels.ll" "/checkout/tests/codegen-llvm/codemodels.rs" "--dump-input-context" "100"
stdout: none
--- stderr -------------------------------
error: no check strings found with prefix 'CHECK:'
------------------------------------------


---- [codegen] tests/codegen-llvm/codemodels.rs#MODEL-MEDIUM stdout ----

error in revision `MODEL-MEDIUM`: verification with 'FileCheck' failed
status: exit status: 2
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen-llvm/codemodels.MODEL-MEDIUM/codemodels.ll" "/checkout/tests/codegen-llvm/codemodels.rs" "--dump-input-context" "100"
stdout: none
--- stderr -------------------------------
error: no check strings found with prefix 'CHECK:'
------------------------------------------


---- [codegen] tests/codegen-llvm/codemodels.rs#MODEL-SMALL stdout ----

error in revision `MODEL-SMALL`: verification with 'FileCheck' failed
status: exit status: 2
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen-llvm/codemodels.MODEL-SMALL/codemodels.ll" "/checkout/tests/codegen-llvm/codemodels.rs" "--dump-input-context" "100"
stdout: none
--- stderr -------------------------------
error: no check strings found with prefix 'CHECK:'
------------------------------------------


---- [codegen] tests/codegen-llvm/codemodels.rs#NOMODEL stdout ----

error in revision `NOMODEL`: verification with 'FileCheck' failed
status: exit status: 2
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen-llvm/codemodels.NOMODEL/codemodels.ll" "/checkout/tests/codegen-llvm/codemodels.rs" "--dump-input-context" "100"
stdout: none
--- stderr -------------------------------
error: no check strings found with prefix 'CHECK:'
------------------------------------------


---- [codegen] tests/codegen-llvm/simd/packed-simd.rs#opt3 stdout ----

error in revision `opt3`: verification with 'FileCheck' failed
status: exit status: 2
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen-llvm/simd/packed-simd.opt3/packed-simd.ll" "/checkout/tests/codegen-llvm/simd/packed-simd.rs" "--dump-input-context" "100" "--check-prefixes=CHECK,opt3"
stdout: none
--- stderr -------------------------------
error: no check strings found with prefix 'opt3:'
------------------------------------------

@rust-bors
Copy link

rust-bors bot commented Aug 16, 2025

💔 Test for 37206fb failed: CI. Failed jobs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc PG-exploit-mitigations Project group: Exploit mitigations rla-silenced Silences rust-log-analyzer postings to the PR it's added on. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compiletest: FileCheck-based tests conflate FileCheck prefixes with compiletest revisions
3 participants
@tgross35 @rustbot @rust-log-analyzer