Unify wording of resolve error by estebank · Pull Request #145399 · rust-lang/rust

estebank · 2025-08-14T16:13:00Z

Remove "failed to resolve" from the main error message and use the same format we use in other resolution errors "cannot find name":

error[E0433]: cannot find `nonexistent` in `existent`
  --> $DIR/custom_attr_multisegment_error.rs:5:13
   |
LL | #[existent::nonexistent]
   |             ^^^^^^^^^^^ could not find `nonexistent` in `existent`

The intent behind this is to end up with all resolve errors eventually be on the form of

error[ECODE]: cannot find `{NAME}` in {SCOPE}
  --> $DIR/file.rs:5:13
   |
LL | #[existent::nonexistent]
   |             ^^^^^^^^^^^ {SPECIFIC LABEL}

A category of errors that is interest are those that involve keywords. For example:

error[E0433]: cannot find `Self` in this scope
  --> $DIR/issue-97194.rs:2:35
   |
LL |     fn bget(&self, index: [usize; Self::DIM]) -> bool {
   |                                   ^^^^ `Self` is only available in impls, traits, and type definitions

and

error[E0433]: cannot find `super` in this scope
  --> $DIR/keyword-super.rs:2:9
   |
LL |     let super: isize;
   |         ^^^^^ there are too many leading `super` keywords

For these the label provides the actual help, while the message is less informative beyond telling you "couldn't find name".

This is an off-shoot of #126810 and #128086, a subset of the intended changes there with review comments applied.

r? @petrochenkov

rustbot · 2025-08-14T16:13:08Z

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

tests/ui/extern/extern-macro.stderr

tests/ui/suggestions/crate-or-module-typo.stderr

tests/ui/macros/issue-111749.rs

compiler/rustc_resolve/src/ident.rs

tests/ui/issues/issue-46101.stderr

petrochenkov · 2026-02-12T13:45:02Z

Not sure what is the status here, the PR was updated at some point, but never marked as waiting on review.

estebank · 2026-02-12T23:16:24Z

If the wording changes are agreeable (which #145399 (comment) makes it sound like it might be), I can try to clean up the PR again into a mergable state.

petrochenkov · 2026-02-13T06:16:08Z

Yes, I think we can rebase and merge this.
Now I remember that I did full review and the two comments above was everything that I thought needed addressing.

rustbot · 2026-02-13T19:22:56Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

The Miri subtree was changed

cc @rust-lang/miri

@petrochenkov

…r=petrochenkov Unify wording of resolve error Remove "failed to resolve" from the main error message and use the same format we use in other resolution errors "cannot find `name`": ``` error[E0433]: cannot find `nonexistent` in `existent` --> $DIR/custom_attr_multisegment_error.rs:5:13 | LL | #[existent::nonexistent] | ^^^^^^^^^^^ could not find `nonexistent` in `existent` ``` The intent behind this is to end up with all resolve errors eventually be on the form of ``` error[ECODE]: cannot find `{NAME}` in {SCOPE} --> $DIR/file.rs:5:13 | LL | #[existent::nonexistent] | ^^^^^^^^^^^ {SPECIFIC LABEL} ``` A category of errors that is interest are those that involve keywords. For example: ``` error[E0433]: cannot find `Self` in this scope --> $DIR/issue-97194.rs:2:35 | LL | fn bget(&self, index: [usize; Self::DIM]) -> bool { | ^^^^ `Self` is only available in impls, traits, and type definitions ``` and ``` error[E0433]: cannot find `super` in this scope --> $DIR/keyword-super.rs:2:9 | LL | let super: isize; | ^^^^^ there are too many leading `super` keywords ``` For these the label provides the actual help, while the message is less informative beyond telling you "couldn't find `name`". This is an off-shoot of rust-lang#126810 and rust-lang#128086, a subset of the intended changes there with review comments applied. r? @petrochenkov

Rollup of 6 pull requests Successful merges: - #145399 (Unify wording of resolve error) - #152512 (core: Implement feature `float_exact_integer_constants`) - #152661 (Avoid ICE in From/TryFrom diagnostic under -Znext-solver) - #152703 (Remove `rustc_query_system`) - #152727 (`probe_op` silence ambiguity errors if tainted) - #152728 (Port #![default_lib_allocator] to the new attribute parser)

Zalathar · 2026-02-17T01:59:57Z

Possibly failed in rollup in aarch64-msvc-1: #152736 (comment)

@bors r-
@bors try jobs=aarch64-msvc-1

Unify wording of resolve error try-job: aarch64-msvc-1

Remove "failed to resolve" and use the same format we use in other resolution errors "cannot find `name`". ``` error[E0433]: cannot find `nonexistent` in `existent` --> $DIR/custom_attr_multisegment_error.rs:5:13 | LL | #[existent::nonexistent] | ^^^^^^^^^^^ could not find `nonexistent` in `existent` ```

rustbot · 2026-02-17T16:52:10Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

estebank · 2026-02-18T01:36:10Z

@bors r=petrochenkov

rust-bors · 2026-02-18T01:36:13Z

📌 Commit 257a415 has been approved by petrochenkov

It is now in the queue for this repository.

@petrochenkov

…r=petrochenkov Unify wording of resolve error Remove "failed to resolve" from the main error message and use the same format we use in other resolution errors "cannot find `name`": ``` error[E0433]: cannot find `nonexistent` in `existent` --> $DIR/custom_attr_multisegment_error.rs:5:13 | LL | #[existent::nonexistent] | ^^^^^^^^^^^ could not find `nonexistent` in `existent` ``` The intent behind this is to end up with all resolve errors eventually be on the form of ``` error[ECODE]: cannot find `{NAME}` in {SCOPE} --> $DIR/file.rs:5:13 | LL | #[existent::nonexistent] | ^^^^^^^^^^^ {SPECIFIC LABEL} ``` A category of errors that is interest are those that involve keywords. For example: ``` error[E0433]: cannot find `Self` in this scope --> $DIR/issue-97194.rs:2:35 | LL | fn bget(&self, index: [usize; Self::DIM]) -> bool { | ^^^^ `Self` is only available in impls, traits, and type definitions ``` and ``` error[E0433]: cannot find `super` in this scope --> $DIR/keyword-super.rs:2:9 | LL | let super: isize; | ^^^^^ there are too many leading `super` keywords ``` For these the label provides the actual help, while the message is less informative beyond telling you "couldn't find `name`". This is an off-shoot of rust-lang#126810 and rust-lang#128086, a subset of the intended changes there with review comments applied. r? @petrochenkov

@petrochenkov

…r=petrochenkov Unify wording of resolve error Remove "failed to resolve" from the main error message and use the same format we use in other resolution errors "cannot find `name`": ``` error[E0433]: cannot find `nonexistent` in `existent` --> $DIR/custom_attr_multisegment_error.rs:5:13 | LL | #[existent::nonexistent] | ^^^^^^^^^^^ could not find `nonexistent` in `existent` ``` The intent behind this is to end up with all resolve errors eventually be on the form of ``` error[ECODE]: cannot find `{NAME}` in {SCOPE} --> $DIR/file.rs:5:13 | LL | #[existent::nonexistent] | ^^^^^^^^^^^ {SPECIFIC LABEL} ``` A category of errors that is interest are those that involve keywords. For example: ``` error[E0433]: cannot find `Self` in this scope --> $DIR/issue-97194.rs:2:35 | LL | fn bget(&self, index: [usize; Self::DIM]) -> bool { | ^^^^ `Self` is only available in impls, traits, and type definitions ``` and ``` error[E0433]: cannot find `super` in this scope --> $DIR/keyword-super.rs:2:9 | LL | let super: isize; | ^^^^^ there are too many leading `super` keywords ``` For these the label provides the actual help, while the message is less informative beyond telling you "couldn't find `name`". This is an off-shoot of rust-lang#126810 and rust-lang#128086, a subset of the intended changes there with review comments applied. r? @petrochenkov

Rollup of 19 pull requests Successful merges: - #145399 (Unify wording of resolve error) - #150473 (tail calls: fix copying non-scalar arguments to callee) - #152637 (Add a note about elided lifetime) - #152657 (std: move `exit` out of PAL) - #152729 (compiler: Don't mark `SingleUseConsts` MIR pass as "required for soundness") - #152753 (remove the explicit error for old `rental` versions) - #152758 (Remove ShallowInitBox.) - #151530 (Fix invalid `mut T` suggestion for `&mut T` in missing lifetime error) - #152179 (Add documentation note about signed overflow direction) - #152474 (Implement opt-bisect-limit for MIR) - #152509 (tests/ui/test-attrs: add annotations for reference rules) - #152672 (std: use libc version of `_NSGetArgc`/`_NSGetArgv`) - #152711 (resolve: Disable an assert that no longer holds) - #152732 (add regression test for 147958) - #152745 (Fix ICE in `suggest_param_env_shadowing` with incompatible args) - #152749 (make `rustc_allow_const_fn_unstable` an actual `rustc_attrs` attribute) - #152756 (Miri: recursive validity: also recurse into Boxes) - #152770 (carryless_mul: mention the base) - #152778 (Update tracking issue number for final_associated_functions)

Rollup of 20 pull requests Successful merges: - #145399 (Unify wording of resolve error) - #150473 (tail calls: fix copying non-scalar arguments to callee) - #152637 (Add a note about elided lifetime) - #152729 (compiler: Don't mark `SingleUseConsts` MIR pass as "required for soundness") - #152751 (Rename dep node "fingerprints" to distinguish key and value hashes) - #152753 (remove the explicit error for old `rental` versions) - #152758 (Remove ShallowInitBox.) - #151530 (Fix invalid `mut T` suggestion for `&mut T` in missing lifetime error) - #152179 (Add documentation note about signed overflow direction) - #152474 (Implement opt-bisect-limit for MIR) - #152509 (tests/ui/test-attrs: add annotations for reference rules) - #152672 (std: use libc version of `_NSGetArgc`/`_NSGetArgv`) - #152711 (resolve: Disable an assert that no longer holds) - #152725 (Rework explanation of CLI lint level flags) - #152732 (add regression test for 147958) - #152745 (Fix ICE in `suggest_param_env_shadowing` with incompatible args) - #152749 (make `rustc_allow_const_fn_unstable` an actual `rustc_attrs` attribute) - #152756 (Miri: recursive validity: also recurse into Boxes) - #152770 (carryless_mul: mention the base) - #152778 (Update tracking issue number for final_associated_functions)

@petrochenkov

Rollup merge of #145399 - estebank:resolve-error-wording-2, r=petrochenkov Unify wording of resolve error Remove "failed to resolve" from the main error message and use the same format we use in other resolution errors "cannot find `name`": ``` error[E0433]: cannot find `nonexistent` in `existent` --> $DIR/custom_attr_multisegment_error.rs:5:13 | LL | #[existent::nonexistent] | ^^^^^^^^^^^ could not find `nonexistent` in `existent` ``` The intent behind this is to end up with all resolve errors eventually be on the form of ``` error[ECODE]: cannot find `{NAME}` in {SCOPE} --> $DIR/file.rs:5:13 | LL | #[existent::nonexistent] | ^^^^^^^^^^^ {SPECIFIC LABEL} ``` A category of errors that is interest are those that involve keywords. For example: ``` error[E0433]: cannot find `Self` in this scope --> $DIR/issue-97194.rs:2:35 | LL | fn bget(&self, index: [usize; Self::DIM]) -> bool { | ^^^^ `Self` is only available in impls, traits, and type definitions ``` and ``` error[E0433]: cannot find `super` in this scope --> $DIR/keyword-super.rs:2:9 | LL | let super: isize; | ^^^^^ there are too many leading `super` keywords ``` For these the label provides the actual help, while the message is less informative beyond telling you "couldn't find `name`". This is an off-shoot of #126810 and #128086, a subset of the intended changes there with review comments applied. r? @petrochenkov

Rollup of 20 pull requests Successful merges: - rust-lang/rust#145399 (Unify wording of resolve error) - rust-lang/rust#150473 (tail calls: fix copying non-scalar arguments to callee) - rust-lang/rust#152637 (Add a note about elided lifetime) - rust-lang/rust#152729 (compiler: Don't mark `SingleUseConsts` MIR pass as "required for soundness") - rust-lang/rust#152751 (Rename dep node "fingerprints" to distinguish key and value hashes) - rust-lang/rust#152753 (remove the explicit error for old `rental` versions) - rust-lang/rust#152758 (Remove ShallowInitBox.) - rust-lang/rust#151530 (Fix invalid `mut T` suggestion for `&mut T` in missing lifetime error) - rust-lang/rust#152179 (Add documentation note about signed overflow direction) - rust-lang/rust#152474 (Implement opt-bisect-limit for MIR) - rust-lang/rust#152509 (tests/ui/test-attrs: add annotations for reference rules) - rust-lang/rust#152672 (std: use libc version of `_NSGetArgc`/`_NSGetArgv`) - rust-lang/rust#152711 (resolve: Disable an assert that no longer holds) - rust-lang/rust#152725 (Rework explanation of CLI lint level flags) - rust-lang/rust#152732 (add regression test for 147958) - rust-lang/rust#152745 (Fix ICE in `suggest_param_env_shadowing` with incompatible args) - rust-lang/rust#152749 (make `rustc_allow_const_fn_unstable` an actual `rustc_attrs` attribute) - rust-lang/rust#152756 (Miri: recursive validity: also recurse into Boxes) - rust-lang/rust#152770 (carryless_mul: mention the base) - rust-lang/rust#152778 (Update tracking issue number for final_associated_functions)

rustbot assigned petrochenkov Aug 14, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 14, 2025

This comment has been minimized.

Sign in to view

estebank force-pushed the resolve-error-wording-2 branch from fd49d2a to 298dec7 Compare August 14, 2025 16:32

estebank commented Aug 14, 2025

View reviewed changes

tests/ui/extern/extern-macro.stderr Show resolved Hide resolved

estebank commented Aug 14, 2025

View reviewed changes

tests/ui/suggestions/crate-or-module-typo.stderr Outdated Show resolved Hide resolved

estebank added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 14, 2025

This comment has been minimized.

Sign in to view

petrochenkov reviewed Aug 15, 2025

View reviewed changes

tests/ui/macros/issue-111749.rs Outdated Show resolved Hide resolved

compiler/rustc_resolve/src/ident.rs Outdated Show resolved Hide resolved

petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 15, 2025

estebank force-pushed the resolve-error-wording-2 branch 2 times, most recently from 0b0bd12 to f6ce33d Compare August 15, 2025 19:28

estebank commented Aug 15, 2025

View reviewed changes

tests/ui/issues/issue-46101.stderr Show resolved Hide resolved

This comment has been minimized.

Sign in to view

This comment was marked as resolved.

Sign in to view

petrochenkov mentioned this pull request Feb 12, 2026

Tweak output of resolve errors #126810

Closed

estebank force-pushed the resolve-error-wording-2 branch from 6890c8d to 830b1d7 Compare February 13, 2026 19:22

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs T-clippy Relevant to the Clippy team. labels Feb 13, 2026

This comment has been minimized.

Sign in to view

estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 13, 2026

jhpratt mentioned this pull request Feb 16, 2026

Rollup of 6 pull requests #152736

Closed

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 17, 2026

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Feb 17, 2026

Auto merge of #145399 - estebank:resolve-error-wording-2, r=<try>

93f0a83

Unify wording of resolve error try-job: aarch64-msvc-1

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

estebank added 2 commits February 17, 2026 16:51

Make suggestion verbose and fix incorrect suggestion usage

257a415

estebank force-pushed the resolve-error-wording-2 branch from 61211ba to 257a415 Compare February 17, 2026 16:52

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 18, 2026

jhpratt mentioned this pull request Feb 18, 2026

Rollup of 20 pull requests #152781

Closed

jhpratt mentioned this pull request Feb 18, 2026

Rollup of 19 pull requests #152782

Closed

Zalathar mentioned this pull request Feb 18, 2026

Rollup of 20 pull requests #152785

Merged

rust-bors bot merged commit efbc895 into rust-lang:main Feb 18, 2026
11 checks passed

rustbot added this to the 1.95.0 milestone Feb 18, 2026

Uh oh!

Comments

Conversation

estebank commented Aug 14, 2025 • edited by petrochenkov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 14, 2025

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment was marked as resolved.

petrochenkov commented Feb 12, 2026

Uh oh!

estebank commented Feb 12, 2026

Uh oh!

petrochenkov commented Feb 13, 2026

Uh oh!

rustbot commented Feb 13, 2026

Uh oh!

This comment has been minimized.

Zalathar commented Feb 17, 2026

Uh oh!

This comment was marked as outdated.

This comment has been minimized.

This comment was marked as outdated.

This comment has been minimized.

rustbot commented Feb 17, 2026

Uh oh!

estebank commented Feb 18, 2026

Uh oh!

rust-bors bot commented Feb 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

estebank commented Aug 14, 2025 •

edited by petrochenkov

Loading