[BETA] Revert "Use DeepRejectCtxt in assemble_inherent_candidates_from_param" #145396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ad59f0b.
rustbot
added
S-waiting-on-review
Collaborator
|
compiler-errors
added
beta-nominated
traviscross
added
the
I-lang-radar
lcnr
changed the title
Contributor
|
r=me |
Contributor
|
discussed in the compiler meeting https://rust-lang.zulipchat.com/#narrow/channel/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202025-08-14/near/534498214 @bors r+ |
Collaborator
bors
added
S-waiting-on-bors
Member
Author
|
@bors rollup=never |
Member
|
@bors p=10 as per https://forge.rust-lang.org/compiler/reviews.html#priority (beta backport) and mostly because we currently have 10 rollup=never PRs in the queue. |
bors
added a commit
that referenced
this pull request
Aug 16, 2025
[BETA] Revert "Use DeepRejectCtxt in assemble_inherent_candidates_from_param" Fixes #145185. Backporting this to stable and beta in favor of #145262 (comment). r? lcnr
Collaborator
Collaborator
|
💔 Test failed - checks-actions |
bors
removed
the
S-waiting-on-bors
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 16, 2025
[BETA] Revert "Use DeepRejectCtxt in assemble_inherent_candidates_from_param" Fixes #145185. Backporting this to stable and beta in favor of #145262 (comment). r? lcnr
Collaborator
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Member
|
Network o.O ... again! At least 3 PRs have failed due to network issues in the last <24 hours, might need to bring this to T-infra... @bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 16, 2025
[BETA] Revert "Use DeepRejectCtxt in assemble_inherent_candidates_from_param" Fixes #145185. Backporting this to stable and beta in favor of #145262 (comment). r? lcnr
Collaborator
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Member
|
Network failure (#t-infra > Non-stop network timeouts across auto-builds) @bors retry |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
cuviper
removed
the
beta-nominated
Member
|
I don't think we ever did stable (1.89) for this, but it's too late now, so I'm clearing labels. @rustbot label -stable-nominated -stable-accepted. |
rustbot
removed
stable-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145185.
Backporting this to stable and beta in favor of #145262 (comment).
r? lcnr