Skip to content

Implement Show for Bitv{,Set} #14535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2014
Merged

Implement Show for Bitv{,Set} #14535

merged 1 commit into from
May 30, 2014

Conversation

sfackler
Copy link
Member

Closes #14531

@huonw
Copy link
Member

huonw commented May 30, 2014

No test for Bitv?

bors added a commit that referenced this pull request May 30, 2014
@sfackler
Copy link
Member Author

There was already a test for the old to_str function that now tests the Show impl.

@bors bors closed this May 30, 2014
@bors bors merged commit 8e8f6a0 into rust-lang:master May 30, 2014
@sfackler sfackler deleted the bitv-show branch November 26, 2016 05:54
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2023
…lder-for-discovery-cwd, r=Veykril

fix: when running the "discoverProjectCommand", use the Rust file's parent directory instead of the workspace folder

This is a quick fix to allow the `discoverProjectCommand` to run successfully when the user has a workspace that does not, e.g., have a `.buckconfig` defined.

(It's also probably _more correct_ to set the `pwd` of the command to the parent of the Rust file _anyways_ rather than relying on the workspace folders, which may be entirely unrelated.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bitv and BitvSet do not not implement Show
4 participants