Skip to content

stall ConstArgHasType in compute_goal_fast_path#144702

Merged
bors merged 1 commit intorust-lang:masterfrom
compiler-errors:stall-const-arg-has-type
Jul 31, 2025
Merged

stall ConstArgHasType in compute_goal_fast_path#144702
bors merged 1 commit intorust-lang:masterfrom
compiler-errors:stall-const-arg-has-type

Conversation

@compiler-errors
Copy link
Contributor

@compiler-errors compiler-errors commented Jul 30, 2025

I'm having major deja-vu about this; I thought that already implemented this but 🤷 maybe not.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jul 30, 2025
@compiler-errors
Copy link
Contributor Author

compiler-errors commented Jul 30, 2025

@bors2 try @rust-timer queue

After this experiment I want to also see if we should do a fast path for param-env lookup and structually matching the ty.

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link
Contributor

rust-bors bot commented Jul 30, 2025

⌛ Trying commit 585eac8 with merge b777317…

To cancel the try build, run the command @bors try cancel.

rust-bors bot added a commit that referenced this pull request Jul 30, 2025
@rust-bors
Auto merge of #144702 - compiler-errors:stall-const-arg-has-type, r=<…
b777317 
…try>

stall `ConstArgHasType` in `compute_goal_fast_path`
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 30, 2025
@rust-bors
Copy link
Contributor

rust-bors bot commented Jul 30, 2025

☀️ Try build successful (CI)
Build commit: b777317 (b777317f41894dcd557aad152a29373e0288bf31, parent: e5e79f8bd428d0b8d26e8240d718b134ef297459)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

rust-timer commented Jul 31, 2025

Finished benchmarking commit (b777317): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.5% [0.8%, 2.3%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.8% [-2.8%, -2.8%] 1
All ❌✅ (primary) - - 0

Cycles

Results (primary 2.5%, secondary 3.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.5% [2.5%, 2.5%] 1
Regressions ❌
(secondary)		 3.3% [3.3%, 3.3%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.5% [2.5%, 2.5%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 469.342s -> 470.258s (0.20%)
Artifact size: 376.86 MiB -> 376.84 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 31, 2025
@compiler-errors compiler-errors marked this pull request as ready for review July 31, 2025 13:14
@rustbot
Copy link
Collaborator

rustbot commented Jul 31, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@compiler-errors
Copy link
Contributor Author

compiler-errors commented Jul 31, 2025

This is kinda whatever but I think it can still land because it seems useful in the abstract sense and likely not to make things slower in a concrete sense.

r? lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 31, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 31, 2025

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@lcnr
Copy link
Contributor

lcnr commented Jul 31, 2025

Given the perf impact 🤔

@bors r+ rollup=always

@bors
Copy link
Collaborator

bors commented Jul 31, 2025

📌 Commit 585eac8 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2025
@jdonszelmann jdonszelmann mentioned this pull request Jul 31, 2025
Merged
bors added a commit that referenced this pull request Jul 31, 2025
@bors
Auto merge of #144740 - jdonszelmann:rollup-nprgqnm, r=jdonszelmann
adcb3d3 
Rollup of 6 pull requests

Successful merges:

 - #144688 (Uniform `enter_trace_span!` and add documentation)
 - #144702 (stall `ConstArgHasType` in `compute_goal_fast_path`)
 - #144711 (Consider operator's span when computing binop expr span)
 - #144712 (Deduplicate `IntTy`/`UintTy`/`FloatTy`.)
 - #144726 (merge rustc_attr_data_structures into rustc_hir)
 - #144733 (fix: Match width of ascii and unicode secondary file start)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit eec13cd into rust-lang:master Jul 31, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 31, 2025
rust-timer added a commit that referenced this pull request Jul 31, 2025
@rust-timer
Unrolled build for #144702
4b0234e 
Rollup merge of #144702 - compiler-errors:stall-const-arg-has-type, r=lcnr

stall `ConstArgHasType` in `compute_goal_fast_path`

I'm having major deja-vu about this; I thought that already implemented this but 🤷 maybe not.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Aug 1, 2025
@bors
Auto merge of #144740 - jdonszelmann:rollup-nprgqnm, r=jdonszelmann
5825740 
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#144688 (Uniform `enter_trace_span!` and add documentation)
 - rust-lang/rust#144702 (stall `ConstArgHasType` in `compute_goal_fast_path`)
 - rust-lang/rust#144711 (Consider operator's span when computing binop expr span)
 - rust-lang/rust#144712 (Deduplicate `IntTy`/`UintTy`/`FloatTy`.)
 - rust-lang/rust#144726 (merge rustc_attr_data_structures into rustc_hir)
 - rust-lang/rust#144733 (fix: Match width of ascii and unicode secondary file start)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-cloud-vms bot pushed a commit to makai410/rustc_public that referenced this pull request Aug 16, 2025
@bors
Auto merge of #144740 - jdonszelmann:rollup-nprgqnm, r=jdonszelmann
28a13c5 
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#144688 (Uniform `enter_trace_span!` and add documentation)
 - rust-lang/rust#144702 (stall `ConstArgHasType` in `compute_goal_fast_path`)
 - rust-lang/rust#144711 (Consider operator's span when computing binop expr span)
 - rust-lang/rust#144712 (Deduplicate `IntTy`/`UintTy`/`FloatTy`.)
 - rust-lang/rust#144726 (merge rustc_attr_data_structures into rustc_hir)
 - rust-lang/rust#144733 (fix: Match width of ascii and unicode secondary file start)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-cloud-vms bot pushed a commit to makai410/rustc_public that referenced this pull request Aug 20, 2025
@bors
Auto merge of #144740 - jdonszelmann:rollup-nprgqnm, r=jdonszelmann
d30af38 
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#144688 (Uniform `enter_trace_span!` and add documentation)
 - rust-lang/rust#144702 (stall `ConstArgHasType` in `compute_goal_fast_path`)
 - rust-lang/rust#144711 (Consider operator's span when computing binop expr span)
 - rust-lang/rust#144712 (Deduplicate `IntTy`/`UintTy`/`FloatTy`.)
 - rust-lang/rust#144726 (merge rustc_attr_data_structures into rustc_hir)
 - rust-lang/rust#144733 (fix: Match width of ascii and unicode secondary file start)

r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
@bors
Auto merge of rust-lang#144740 - jdonszelmann:rollup-nprgqnm, r=jdons…
4352e18 
…zelmann

Rollup of 6 pull requests

Successful merges:

 - rust-lang#144688 (Uniform `enter_trace_span!` and add documentation)
 - rust-lang#144702 (stall `ConstArgHasType` in `compute_goal_fast_path`)
 - rust-lang#144711 (Consider operator's span when computing binop expr span)
 - rust-lang#144712 (Deduplicate `IntTy`/`UintTy`/`FloatTy`.)
 - rust-lang#144726 (merge rustc_attr_data_structures into rustc_hir)
 - rust-lang#144733 (fix: Match width of ascii and unicode secondary file start)

r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
@bors
Auto merge of #144740 - jdonszelmann:rollup-nprgqnm, r=jdonszelmann
64c49f4 
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#144688 (Uniform `enter_trace_span!` and add documentation)
 - rust-lang/rust#144702 (stall `ConstArgHasType` in `compute_goal_fast_path`)
 - rust-lang/rust#144711 (Consider operator's span when computing binop expr span)
 - rust-lang/rust#144712 (Deduplicate `IntTy`/`UintTy`/`FloatTy`.)
 - rust-lang/rust#144726 (merge rustc_attr_data_structures into rustc_hir)
 - rust-lang/rust#144733 (fix: Match width of ascii and unicode secondary file start)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lcnr lcnr

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

1.90.0

Development

Successfully merging this pull request may close these issues.

6 participants

@compiler-errors @rust-timer @rustbot @lcnr @bors @SparrowLii