-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Add explicit download methods to download module in bootstrap #144482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bors
merged 7 commits into
rust-lang:master
from
Shourya742:2025-07-24-have-explicit-download-methods
Jul 29, 2025
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3d3534d
add download context
Shourya742 861de92
move utility methods out of config impl
Shourya742 8facd06
move download_beta_toolchain out of impl as its used during config in…
Shourya742 19dc195
move download_rustfmt out of impl as its used during config initializ…
Shourya742 f63f212
use dry_run and verbose directly from exec_ctx
Shourya742 db42d5b
remove config wrappers of download_toolchain and maybe_download_fmt a…
Shourya742 c071101
make sure to populate DownloadState dependencies before its initializ…
Shourya742 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.