-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Cleanup lifetime and pointer guides #14387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup lifetime and pointer guides #14387
Conversation
Clean pointers guide
src/doc/guide-lifetimes.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use emphasis around here, it's distracting.
Thanks for doing this! Clean docs are really important. |
…inters" section back to pointers guide
ready for a second review. |
Comments from someone on IRC:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub won’t let me comment on it, but four lines up (line 290/197) it reads ‘Here, as before, the interior of the variable x
…’. That previous section was removed, so you should probably remove the ‘as before’ part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohhh, nice catch! thanks
Ready for a third review. |
… r=brson My main goals were: - be clear when we talk about "references" and "pointers" - remove Managed boxes completely and the concept of GC. #13987
…hrough unions (rust-lang#14387) This requires making the `deref_addrof` lint a late lint instead of an early lint to check for types. changelog: [`deref_addrof`]: do not suggest implicit `DerefMut` on `ManuallyDrop` union fields Fix rust-lang/rust-clippy#14386
My main goals were:
#13987