Remove false label when self resolve failure does not relate to macro
#143177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
lcnr
reviewed
Jul 3, 2025
lcnr
added
S-waiting-on-author
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
xizheyin
changed the title
self when it occur in let bindingsself resolve failure does not relate to macro
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
xizheyin
commented
Jul 3, 2025
| let is_assoc_fn = self.self_type_is_available(); | ||
| let self_from_macro = "a `self` parameter, but a macro invocation can only \ | ||
| access identifiers it receives from parameters"; | ||
| if let Some((fn_kind, span)) = &self.diag_metadata.current_function { | ||
| if let Some((fn_kind, fn_span)) = &self.diag_metadata.current_function { |
There was a problem hiding this comment.
I keep the fn_span change because span shadow make it confused.
Comment on lines
+1186
to
+1192
|
|
||
| // using `let self` is wrong even if we're not in an associated method or if we're in a macro expansion. | ||
| // So, we should return early if we're in a pattern, see issue #143134. | ||
| if matches!(source, PathSource::Pat) { | ||
| return true; | ||
| } | ||
|
|
There was a problem hiding this comment.
I return early when the source is Pat.
Comment on lines
-43
to
-44
| LL | fn main () { | ||
| | ---- this function can't have a `self` parameter |
There was a problem hiding this comment.
It indeed bring some benefits. :)
rustbot
added
S-waiting-on-review
|
thx @bors r+ rollup |
bors
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 9, 2025
Remove false label when `self` resolve failure does not relate to macro Fixes rust-lang#143134 In the first commit, I did some code-clean, moving `suggest*` to `suggestions/` dir. In the second, commit, I added ui test. In the third, I change the code, and present the test result. r? compiler
bors
added a commit
that referenced
this pull request
Jul 9, 2025
Rollup of 11 pull requests Successful merges: - #143177 (Remove false label when `self` resolve failure does not relate to macro) - #143339 (Respect endianness correctly in CheckEnums test suite) - #143426 (clippy fix: indentation) - #143499 (Don't call `predicates_of` on a dummy obligation cause's body id) - #143520 (Fix perf regression caused by tracing) - #143532 (More carefully consider span context when suggesting remove `&mut`) - #143606 (configure.py: Write last key in each section) - #143632 (fix: correct parameter names in LLVMRustBuildMinNum and LLVMRustBuildMaxNum FFI declarations) - #143644 (Add triagebot stdarch mention ping) - #143651 (Win: Use exceptions with empty data for SEH panic exception copies instead of a new panic) - #143660 (Disable docs for `compiler-builtins` and `sysroot`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Jul 9, 2025
Rollup of 9 pull requests Successful merges: - #142357 (Simplify LLVM bitcode linker in bootstrap and add tests for it) - #143177 (Remove false label when `self` resolve failure does not relate to macro) - #143339 (Respect endianness correctly in CheckEnums test suite) - #143426 (clippy fix: indentation) - #143475 (tests: Use `cfg_target_has_reliable_f16_f128` in `conv-bits-runtime-const`) - #143499 (Don't call `predicates_of` on a dummy obligation cause's body id) - #143520 (Fix perf regression caused by tracing) - #143532 (More carefully consider span context when suggesting remove `&mut`) - #143606 (configure.py: Write last key in each section) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jul 9, 2025
Rollup merge of #143177 - xizheyin:143134, r=lcnr Remove false label when `self` resolve failure does not relate to macro Fixes #143134 In the first commit, I did some code-clean, moving `suggest*` to `suggestions/` dir. In the second, commit, I added ui test. In the third, I change the code, and present the test result. r? compiler
github-actions bot
pushed a commit
to devnexen/miri
that referenced
this pull request
Jul 10, 2025
Rollup of 9 pull requests Successful merges: - rust-lang/rust#142357 (Simplify LLVM bitcode linker in bootstrap and add tests for it) - rust-lang/rust#143177 (Remove false label when `self` resolve failure does not relate to macro) - rust-lang/rust#143339 (Respect endianness correctly in CheckEnums test suite) - rust-lang/rust#143426 (clippy fix: indentation) - rust-lang/rust#143475 (tests: Use `cfg_target_has_reliable_f16_f128` in `conv-bits-runtime-const`) - rust-lang/rust#143499 (Don't call `predicates_of` on a dummy obligation cause's body id) - rust-lang/rust#143520 (Fix perf regression caused by tracing) - rust-lang/rust#143532 (More carefully consider span context when suggesting remove `&mut`) - rust-lang/rust#143606 (configure.py: Write last key in each section) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143134
In the first commit, I did some code-clean, moving
suggest*tosuggestions/dir.In the second, commit, I added ui test.
In the third, I change the code, and present the test result.
r? compiler