Skip to content

Rollup of 19 pull requests #143061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
e6c3008
small iter.intersperse.fold() optimization
the8472 Jun 15, 2025
644469e
Remove incorrect comments in `Weak`
theemathas Jun 19, 2025
e40515a
add method to retrieve body of coroutine
makai410 Jun 22, 2025
7e683cc
Do not emit `redundant_explicit_links` rustdoc lint if the doc commen…
GuillaumeGomez May 27, 2025
a0d6417
Add ui test for `redundant_explicit_links` rustdoc lint for items com…
GuillaumeGomez May 27, 2025
987c2ff
Update clippy source code to changes on `source_span_for_markdown_range`
GuillaumeGomez May 27, 2025
78cbcaf
Update tests to work with new DocFragment field and `redundant_explic…
GuillaumeGomez Jun 3, 2025
3b5525b
Improve code and documentation
GuillaumeGomez Jun 10, 2025
904652b
Suggest cloning `Arc` moved into closure
estebank May 1, 2024
f908939
rename run_always to run_in_dry_run
Shourya742 Jun 25, 2025
4f80053
Update `browser-ui-test` version to `0.20.7`
GuillaumeGomez Jun 25, 2025
b75b14f
Add `sym::macro_pin` diagnostic item for `core::pin::pin!()`
samueltardieu Jun 25, 2025
8304435
Compute hard errors without diagnostics in impl_intersection_has_impo…
compiler-errors Jun 17, 2025
44254c8
Remove some glob imports from the type system
compiler-errors Jun 17, 2025
c995070
rename RegionVariableOrigin::MiscVariable to RegionVariableOrigin::Misc
compiler-errors Jun 18, 2025
9d11fd0
codegen_fn_attrs: make comment more precise
RalfJung Jun 25, 2025
110cf7e
Report infer ty errors during hir ty lowering
oli-obk Jun 6, 2025
2338821
tests: Do not run afoul of asm.validity.non-exhaustive in input-stats
workingjubilee Jun 11, 2025
1dfc840
make `tidy-alphabetical` use a natural sort
folkertdev May 20, 2025
1aa5e17
Expand const-stabilized API links
jieyouxu Jun 26, 2025
59e1a3c
Simplify IfCause
compiler-errors Jun 25, 2025
ec6f0ea
Remove cache for citool
Kobzol Jun 26, 2025
7960272
Remove workflow run on master
Kobzol Jun 26, 2025
9b3f729
Port `#[used]` to new attribute parsing infrastructure
JonathanBrouwer Jun 25, 2025
7a70f64
Fix RwLock::try_write documentation for WouldBlock condition
krikera Jun 26, 2025
8cddd10
Rollup merge of #124595 - estebank:issue-104232, r=davidtwco
compiler-errors Jun 26, 2025
36e7e6b
Rollup merge of #139594 - compiler-errors:if-cause, r=oli-obk
compiler-errors Jun 26, 2025
52344df
Rollup merge of #141311 - folkertdev:tidy-natural-sort, r=jieyouxu
compiler-errors Jun 26, 2025
8adc333
Rollup merge of #141648 - GuillaumeGomez:redundant_explicit_links-exp…
compiler-errors Jun 26, 2025
4adee2b
Rollup merge of #142285 - workingjubilee:dont-use-bad-assembly, r=nne…
compiler-errors Jun 26, 2025
46cc60b
Rollup merge of #142420 - oli-obk:infer-ty-coalescing, r=compiler-errors
compiler-errors Jun 26, 2025
d055c06
Rollup merge of #142549 - the8472:intersperse-fold-tweak, r=tgross35
compiler-errors Jun 26, 2025
2e82651
Rollup merge of #142637 - compiler-errors:less-globs, r=lcnr
compiler-errors Jun 26, 2025
c96bf8b
Rollup merge of #142647 - compiler-errors:less-work-in-coherence, r=lcnr
compiler-errors Jun 26, 2025
3a6df92
Rollup merge of #142700 - theemathas:remove-weak-comment, r=ibraheemdev
compiler-errors Jun 26, 2025
2dea2cf
Rollup merge of #142818 - JonathanBrouwer:used_new_parser, r=jdonszel…
compiler-errors Jun 26, 2025
20cef17
Rollup merge of #142884 - makai410:coroutine-body, r=celinval
compiler-errors Jun 26, 2025
2fe6b79
Rollup merge of #142967 - krikera:fix-rwlock-try-write-docs, r=jhpratt
compiler-errors Jun 26, 2025
4a14342
Rollup merge of #143001 - Shourya742:2025-06-25-rename-run-always, r=…
compiler-errors Jun 26, 2025
f284eb2
Rollup merge of #143010 - GuillaumeGomez:update-browser-ui-test, r=Ko…
compiler-errors Jun 26, 2025
146fe45
Rollup merge of #143015 - samueltardieu:pin-macro-diag-item, r=Urgau
compiler-errors Jun 26, 2025
b375787
Rollup merge of #143020 - RalfJung:codegen_fn_attrs, r=oli-obk
compiler-errors Jun 26, 2025
213e34d
Rollup merge of #143033 - jieyouxu:expand-apis, r=cuviper
compiler-errors Jun 26, 2025
62e9026
Rollup merge of #143041 - Kobzol:matrix-no-cache, r=marcoieni
compiler-errors Jun 26, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove incorrect comments in Weak
It is currently possible to create a dangling `Weak` to a DST by
calling `Weak::new()` for a sized type, then doing an unsized coercion.
Therefore, the comments are wrong.

These comments were added in <#73845>.
As far as I can tell, the guarantee in the comment was only previously
used in the `as_ptr` method. However, the current implementation of
`as_ptr` no longer relies on this guarantee.
  • Loading branch information
theemathas committed Jun 19, 2025
commit 644469e9613253321d09887ffe0fb2c98528ee21
1 change: 0 additions & 1 deletion library/alloc/src/rc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3004,7 +3004,6 @@ pub struct Weak<
// `Weak::new` sets this to `usize::MAX` so that it doesn’t need
// to allocate space on the heap. That's not a value a real pointer
// will ever have because RcInner has alignment at least 2.
// This is only possible when `T: Sized`; unsized `T` never dangle.
ptr: NonNull<RcInner<T>>,
alloc: A,
}
Expand Down
1 change: 0 additions & 1 deletion library/alloc/src/sync.rs
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,6 @@ pub struct Weak<
// `Weak::new` sets this to `usize::MAX` so that it doesn’t need
// to allocate space on the heap. That's not a value a real pointer
// will ever have because RcInner has alignment at least 2.
// This is only possible when `T: Sized`; unsized `T` never dangle.
ptr: NonNull<ArcInner<T>>,
alloc: A,
}
Expand Down
Loading