Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand macros in patterns #14298

Merged
merged 6 commits into from
May 28, 2014
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add AST node for pattern macros
  • Loading branch information
Keegan McAllister committed May 28, 2014
commit 5fdd0e4b05979a0a01ca6c14e0510880d320250c
4 changes: 4 additions & 0 deletions src/librustc/middle/cfg/construct.rs
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,10 @@ impl<'a> CFGBuilder<'a> {
self.pats_all(post.iter().map(|p| *p), vec_exit);
self.add_node(pat.id, [post_exit])
}

ast::PatMac(_) => {
self.tcx.sess.span_bug(pat.span, "unexpanded macro");
}
}
}

Expand Down
6 changes: 6 additions & 0 deletions src/librustc/middle/check_match.rs
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,7 @@ fn pat_ctor_id(cx: &MatchCheckCtxt, p: @Pat) -> Option<ctor> {
None => Some(vec(before.len() + after.len()))
}
}
PatMac(_) => cx.tcx.sess.bug("unexpanded macro"),
}
}

Expand Down Expand Up @@ -849,6 +850,10 @@ fn specialize(cx: &MatchCheckCtxt,
_ => None
}
}
PatMac(_) => {
cx.tcx.sess.span_err(pat_span, "unexpanded macro");
None
}
}
}
}
Expand Down Expand Up @@ -947,6 +952,7 @@ fn find_refutable(cx: &MatchCheckCtxt, pat: &Pat, spans: &mut Vec<Span>) {
}
PatEnum(_,_) => {}
PatVec(..) => { this_pattern!() }
PatMac(_) => cx.tcx.sess.bug("unexpanded macro"),
}
}

Expand Down
4 changes: 4 additions & 0 deletions src/librustc/middle/mem_categorization.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1088,6 +1088,10 @@ impl<'t,TYPER:Typer> MemCategorizationContext<'t,TYPER> {
ast::PatLit(_) | ast::PatRange(_, _) => {
/*always ok*/
}

ast::PatMac(_) => {
self.tcx().sess.span_bug(pat.span, "unexpanded macro");
}
}

Ok(())
Expand Down
3 changes: 3 additions & 0 deletions src/librustc/middle/trans/_match.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2282,6 +2282,9 @@ fn bind_irrefutable_pat<'a>(
bcx.sess().span_bug(pat.span,
"vector patterns are never irrefutable!");
}
ast::PatMac(..) => {
bcx.sess().span_bug(pat.span, "unexpanded macro");
}
ast::PatWild | ast::PatWildMulti | ast::PatLit(_) | ast::PatRange(_, _) => ()
}
return bcx;
Expand Down
5 changes: 5 additions & 0 deletions src/librustc/middle/trans/debuginfo.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2664,6 +2664,11 @@ fn populate_scope_map(cx: &CrateContext,
walk_pattern(cx, sub_pat, scope_stack, scope_map);
}
}

ast::PatMac(_) => {
cx.sess().span_bug(pat.span, "debuginfo::populate_scope_map() - \
Found unexpanded macro.");
}
}
}

Expand Down
2 changes: 2 additions & 0 deletions src/librustc/middle/typeck/check/_match.rs
Original file line number Diff line number Diff line change
Expand Up @@ -722,6 +722,8 @@ pub fn check_pat(pcx: &pat_ctxt, pat: &ast::Pat, expected: ty::t) {
}
fcx.write_ty(pat.id, expected);
}

ast::PatMac(_) => tcx.sess.bug("unexpanded macro"),
}
}

Expand Down
7 changes: 6 additions & 1 deletion src/librustdoc/clean/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1731,7 +1731,12 @@ fn name_from_pat(p: &ast::Pat) -> String {
PatRange(..) => fail!("tried to get argument name from PatRange, \
which is not allowed in function arguments"),
PatVec(..) => fail!("tried to get argument name from pat_vec, \
which is not allowed in function arguments")
which is not allowed in function arguments"),
PatMac(..) => {
warn!("can't document the name of a function argument \
produced by a pattern macro");
"(argument produced by macro)".to_string()
}
}
}

Expand Down
3 changes: 2 additions & 1 deletion src/libsyntax/ast.rs
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,8 @@ pub enum Pat_ {
PatRange(@Expr, @Expr),
// [a, b, ..i, y, z] is represented as
// PatVec(~[a, b], Some(i), ~[y, z])
PatVec(Vec<@Pat> , Option<@Pat>, Vec<@Pat> )
PatVec(Vec<@Pat> , Option<@Pat>, Vec<@Pat> ),
PatMac(Mac),
}

#[deriving(Clone, Eq, TotalEq, Encodable, Decodable, Hash, Show)]
Expand Down
1 change: 1 addition & 0 deletions src/libsyntax/ast_util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -665,6 +665,7 @@ pub fn walk_pat(pat: &Pat, it: |&Pat| -> bool) -> bool {
slice.iter().advance(|&p| walk_pat(p, |p| it(p))) &&
after.iter().advance(|&p| walk_pat(p, |p| it(p)))
}
PatMac(_) => fail!("attempted to analyze unexpanded pattern"),
PatWild | PatWildMulti | PatLit(_) | PatRange(_, _) | PatIdent(_, _, _) |
PatEnum(_, _) => {
true
Expand Down
1 change: 1 addition & 0 deletions src/libsyntax/fold.rs
Original file line number Diff line number Diff line change
Expand Up @@ -770,6 +770,7 @@ pub fn noop_fold_pat<T: Folder>(p: @Pat, folder: &mut T) -> @Pat {
slice.map(|x| folder.fold_pat(x)),
after.iter().map(|x| folder.fold_pat(*x)).collect())
}
PatMac(ref mac) => PatMac(folder.fold_mac(mac)),
};

@Pat {
Expand Down
1 change: 1 addition & 0 deletions src/libsyntax/print/pprust.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1757,6 +1757,7 @@ impl<'a> State<'a> {
|s, &p| s.print_pat(p)));
try!(word(&mut self.s, "]"));
}
ast::PatMac(ref m) => try!(self.print_mac(m)),
}
self.ann.post(self, NodePat(pat))
}
Expand Down
1 change: 1 addition & 0 deletions src/libsyntax/visit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,7 @@ pub fn walk_pat<E: Clone, V: Visitor<E>>(visitor: &mut V, pattern: &Pat, env: E)
visitor.visit_pat(*postpattern, env.clone())
}
}
PatMac(ref macro) => visitor.visit_mac(macro, env),
}
}

Expand Down