Skip to content

rustdoc_json: conversion cleanups #142747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 22, 2025
Merged

rustdoc_json: conversion cleanups #142747

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6854f7d
Use `sym::asterisk` to avoid a `Symbol::intern` call.
nnethercote Jun 17, 2025
4736142
Remove some dead code.
nnethercote Jun 17, 2025
9a59774
Remove some code.
nnethercote Jun 17, 2025
88388f4
Use `FromClean` more.
nnethercote Jun 17, 2025
2878e1c
Rename some methods.
nnethercote Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use FromClean more. 
The `FromClean` trait is used a lot for converting to rustdoc-json
format. But it's not used universally; there are still some ad hoc
functions and methods for converting. This commit fixes this
inconsistency by using `FromClean` more.

The commit also introduces `FromClean` for `Box` and `Option`. This lets
a lot of `as_ref` and `map` calls be removed in favour of simple
`into_json` calls.
  • Loading branch information
@nnethercote
nnethercote committed Jun 21, 2025
commit 88388f45d625efb58faddde5766c224d3b9bcf4f
Loading