Skip to content

Remove the deprecated unstable concat_idents! macro #142704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025
Merged

Remove the deprecated unstable concat_idents! macro #142704

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8ab934
Migrate some tests away from `concat-idents`
tgross35 Jun 19, 2025
c978c89
Move some `issues-*` tests to better homes
tgross35 Jun 19, 2025
0e4de4c
Remove the deprecated `concat_idents!` macro
tgross35 Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move some issues-* tests to better homes 
These tests were updated in the previous commit; while they are being
cleaned up, move them to a non-issue directory.
  • Loading branch information
@tgross35
tgross35 committed Jun 24, 2025
commit c978c8986f700bc8fa83b5f98cc96f41772fa281
2 changes: 0 additions & 2 deletions src/tools/tidy/src/issues.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2071,7 +2071,6 @@ ui/issues/issue-32782.rs
ui/issues/issue-32797.rs
ui/issues/issue-32805.rs
ui/issues/issue-3290.rs
ui/issues/issue-32950.rs
ui/issues/issue-32995-2.rs
ui/issues/issue-32995.rs
ui/issues/issue-33202.rs
Expand Down Expand Up @@ -2341,7 +2340,6 @@ ui/issues/issue-49934.rs
ui/issues/issue-49955.rs
ui/issues/issue-49973.rs
ui/issues/issue-50187.rs
ui/issues/issue-50403.rs
ui/issues/issue-50411.rs
ui/issues/issue-50415.rs
ui/issues/issue-50442.rs
Expand Down
2 changes: 1 addition & 1 deletion src/tools/tidy/src/ui_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ use ignore::Walk;
const ENTRY_LIMIT: u32 = 901;
// FIXME: The following limits should be reduced eventually.

const ISSUES_ENTRY_LIMIT: u32 = 1623;
const ISSUES_ENTRY_LIMIT: u32 = 1619;

const EXPECTED_TEST_FILE_EXTENSIONS: &[&str] = &[
"rs", // test source files
Expand Down
0 tests/ui/issues/issue-32950.rs → tests/ui/derives/nonsense-input-to-debug.rs
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions tests/ui/issues/issue-32950.stderr → ...ui/derives/nonsense-input-to-debug.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
error: `derive` cannot be used on items with type macros
--> $DIR/issue-32950.rs:7:22
--> $DIR/nonsense-input-to-debug.rs:7:22
|
LL | should_be_vec_t: vec![T],
| ^^^^^^^

error: expected type, found `expr` metavariable
--> $DIR/issue-32950.rs:7:22
--> $DIR/nonsense-input-to-debug.rs:7:22
|
LL | should_be_vec_t: vec![T],
| ^^^^^^^
Expand All @@ -17,7 +17,7 @@ LL | should_be_vec_t: vec![T],
= note: this error originates in the macro `vec` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0392]: type parameter `T` is never used
--> $DIR/issue-32950.rs:5:17
--> $DIR/nonsense-input-to-debug.rs:5:17
|
LL | struct Nonsense<T> {
| ^ unused type parameter
Expand Down
0 tests/ui/issues/issue-50403.rs → .../macro-metavar-expr-concat/empty-input.rs
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions tests/ui/issues/issue-50403.stderr → ...ro-metavar-expr-concat/empty-input.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
error: expected identifier or string literal
--> $DIR/issue-50403.rs:6:14
--> $DIR/empty-input.rs:6:14
|
LL | () => { ${concat()} }
| ^^^^^^^^^^

error: expected expression, found `$`
--> $DIR/issue-50403.rs:6:13
--> $DIR/empty-input.rs:6:13
|
LL | () => { ${concat()} }
| ^ expected expression
Expand Down