Misc cleanups of generic_arg_infer related HIR logic
#142678
Open
+16
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
S-waiting-on-review
BoxyUwU
changed the title
generic_arg_infer related logicgeneric_arg_infer related HIR logic
fmease
reviewed
Jun 18, 2025
This comment has been minimized.
This comment has been minimized.
nnethercote
reviewed
Jun 19, 2025
| // SAFETY: `repr(u8)` is required so that `TyKind<()>` and `TyKind<!>` are layout compatible | ||
| #[repr(u8, C)] | ||
| #[derive(Debug, Clone, Copy, HashStable_Generic)] |
There was a problem hiding this comment.
Why these new derives?
There was a problem hiding this comment.
not new I just moved them below all the comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nnethercote