[rustdoc] Fix random failure when JS code is executed when the whole file was not read yet #142496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @notriddle rustbot has assigned @notriddle. Use |
rustbot
added
A-rustdoc-search
|
Some changes occurred in HTML/CSS/JS. |
GuillaumeGomez
force-pushed
the
fix-random-search-failure
branch
from
b43b567 to
40daf23
Compare
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Jun 20, 2025
…ailure, r=lolbinarycat Fix random failure when JS code is executed when the whole file was not read yet Very randomly (and rarely), when I arrived on a page with `?search=something` in the URL, I got this error:  Moving the `initSearch` function at the bottom to ensure everything has been loaded fixes the issue. PS: Sorry for the noise. Pushed to the wrong branch and rust-lang#142496 closed. ><
rust-timer
added a commit
that referenced
this pull request
Jun 21, 2025
Rollup merge of #142497 - GuillaumeGomez:fix-random-search-failure, r=lolbinarycat Fix random failure when JS code is executed when the whole file was not read yet Very randomly (and rarely), when I arrived on a page with `?search=something` in the URL, I got this error:  Moving the `initSearch` function at the bottom to ensure everything has been loaded fixes the issue. PS: Sorry for the noise. Pushed to the wrong branch and #142496 closed. ><
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very randomly (and rarely), when I arrived on a page with
?search=somethingin the URL, I got this error:Moving the
initSearchfunction at the bottom to ensure everything has been loaded fixes the issue.