guide-pointers: minor nits #14247
Merged
guide-pointers: minor nits #14247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -73,7 +73,7 @@ However. | |||
| Here are the use-cases for pointers. I've prefixed them with the name of the | |||
| pointer that satisfies that use-case: | |||
|
|
|||
| 1. Owned: ~Trait must be a pointer, because you don't know the size of the | |||
| 1. Owned: Box<Trait> must be a pointer, because you don't know the size of the | |||
There was a problem hiding this comment.
This should have back-ticks around it because it's code. (It's possibly actually necessarily in this instance, or else the <Trait> will get picked up by the markdown parser as HTML and then just swallowed.)
|
@huonw updated |
|
Nice, thanks. |
bors
added a commit
that referenced
this pull request
May 17, 2014
Not too hot on the second change, welcome a better suggestion/wording.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Mar 13, 2023
generate correct completion edits for missing macro arguments Fixes rust-lang#14246 rust-analyzer used the token at the cursor after macro expansion to decide whether to replace the token at the cursor before macro expansion. In most cases these two are the same but in some cases these can mismatch which can lead to incorrect replacements. For example if an ident/expr macro argument is missing rust-analyzer generates a "missing" identifier as a placeholder, there is only a brace at the cursor. Therefore, rust-analyzer will incorrectly replace the macro brace with the completion in that case leading to rust-lang#14246. Using the expanded token type was intentional. However, this doesn't seem to ever be desirable (this is supported by the fact that there were no tests that relied on this behavior) since the type of edit to perform should always be determined by the token it's actually applied to. Therefore this PR simply switches the relevant match to use the unexpanded token instead
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 3, 2025
Dereferencing string literals in suggestions is redundant. changelog: [`cmp_owned`]: more natural suggestions are provided for string literals now fixes rust-lang#8103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not too hot on the second change, welcome a better suggestion/wording.