Skip to content

[EXPERIMENTAL] Revert mte-ffi changes #142300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[EXPERIMENTAL] Revert mte-ffi changes #142300

wants to merge 2 commits into from
+11 −7

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Jun 10, 2025 •
edited
Loading

Based on

it failed on aarch64 (on the new aarch64-gnu-llvm-19-1 job introduced in this PR)

This feature requires ARMv8.5 or higher. And it has to be enabled. Maybe the CI job runner does not support this extension?

Let's revert the changes to this test in #141576.
However, I can't explain why the test manages to pass on aarch64-gnu but not aarch64-gnu-llvm-1 #141600.

References

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 10, 2025
@jieyouxu

This comment was marked as off-topic.

Sign in to view
@rust-bors

This comment was marked as off-topic.

Sign in to view
rust-bors bot added a commit that referenced this pull request Jun 10, 2025
@rust-bors
Auto merge of #142300 - jieyouxu:exp-partial-revert-141576, r=<try>
de5c40c 
[EXPERIMENTAL] Revert `mte-ffi` changes

See #141600.

try-job: aarch64-gnu
try-job: aarch64-gnu-llvm-19-1
@rust-bors

This comment was marked as off-topic.

Sign in to view
@jieyouxu
Copy link
Member Author

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 10, 2025

⌛ Trying commit e22aa15 with merge 04a207e…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 10, 2025
@rust-bors
Auto merge of #142300 - jieyouxu:exp-partial-revert-141576, r=<try>
04a207e 
[EXPERIMENTAL] Revert `mte-ffi` changes

See #141600.

try-job: aarch64-gnu
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Jun 10, 2025

☀️ Try build successful (CI)
Build commit: 04a207e (04a207ee81457edcc3278859a189c59e4264381f)

@jieyouxu jieyouxu force-pushed the exp-partial-revert-141576 branch from e22aa15 to 3e712e5 Compare June 14, 2025 17:25
@jieyouxu jieyouxu changed the title [EXPERIMENTAL] Revert mte-ffi changes Revert mte-ffi changes Jun 14, 2025
@jieyouxu jieyouxu changed the title Revert mte-ffi changes [EXPERIMENTAL] Revert mte-ffi changes Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-run-make Area: port run-make Makefiles to rmake.rs T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jieyouxu @rust-log-analyzer @rustbot