Skip to content

Miri subtree update #142292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
Jun 10, 2025
Merged

Miri subtree update #142292

merged 44 commits into from
Jun 10, 2025

Conversation

RalfJung
Copy link
Member

r? @ghost

RalfJung and others added 30 commits June 1, 2025 14:58
Make sure to sync on file-io.rs tokio test
native-lib: allow multiple libraries and/or dirs
use File::lock to implement flock, and add a test for File::lock
TB: Add flag to disable the more precise interior mutability tracking
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 10, 2025

The Miri subtree was changed

cc @rust-lang/miri

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 10, 2025

📌 Commit 88e3e68 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2025
@workingjubilee
Copy link
Member

@bors p=1

@bors
Copy link
Collaborator

bors commented Jun 10, 2025

⌛ Testing commit 88e3e68 with merge 1677d46...

@bors
Copy link
Collaborator

bors commented Jun 10, 2025

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 1677d46 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 10, 2025
@bors bors merged commit 1677d46 into rust-lang:master Jun 10, 2025
11 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 10, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8ce2287 (parent) -> 1677d46 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 1677d46cb128cc8f285dbd32b0dc4d7a46437050 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. mingw-check-tidy: 92.9s -> 66.1s (-28.9%)
  2. dist-aarch64-apple: 6852.3s -> 5385.4s (-21.4%)
  3. dist-apple-various: 8234.7s -> 7066.4s (-14.2%)
  4. x86_64-apple-1: 8007.2s -> 6977.5s (-12.9%)
  5. dist-ohos-aarch64: 4623.4s -> 4212.4s (-8.9%)
  6. x86_64-apple-2: 4825.2s -> 4407.8s (-8.7%)
  7. dist-ohos-x86_64: 4498.4s -> 4123.3s (-8.3%)
  8. dist-powerpc64le-linux-musl: 5457.3s -> 5024.1s (-7.9%)
  9. dist-x86_64-apple: 9394.8s -> 10067.5s (7.2%)
  10. dist-powerpc64-linux: 5359.1s -> 5006.7s (-6.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@RalfJung RalfJung deleted the miri-sync branch June 11, 2025 05:53
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1677d46): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.4% [-0.4%, -0.4%] 2
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.1% [-2.1%, -2.1%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.1% [-2.1%, -2.1%] 1

Cycles

Results (secondary -1.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.4% [-1.4%, -1.4%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 755.415s -> 755.082s (-0.04%)
Artifact size: 372.14 MiB -> 372.15 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants