Skip to content

Rollup of 6 pull requests #141995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Conversation

chenyukang
Copy link
Member

@chenyukang chenyukang commented Jun 4, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

folkertdev and others added 13 commits May 19, 2025 17:40
- Move explanations into comments to match style
- Explain the second examples
- Make variable names match the data structure
These tests specifically test 2015 edition behavior, so ensure that they can only be run with this edition
…tion

This allows for testing these tests on editions other than 2015
…es, r=workingjubilee

add s390x z17 target features

tracking issue: rust-lang#130869

earlier target features were added in rust-lang#135630, and rust-lang#135413 (comment) has some extra context on these new features.

r? `@ghost`
cc `@uweigand`
…, r=workingjubilee

Fix incorrect eq_unspanned in TokenStream

Fixes rust-lang#141522

r? `@workingjubilee`

should we remove this function?
since it's used in several places, i'd prefer to keep it.
remove `f16: From<u16>`

it's not a lossless conversation

r? ```@tgross35```
Lightly tweak docs for BTree{Map,Set}::extract_if

- Move explanations into comments to match style
- Explain the second examples
- Make variable names match the data structure

Related rust-lang#70530
…es2, r=compiler-errors

Add more missing 2015 edition directives

These tests specifically test 2015 edition behavior, so ensure that they can only be run with this edition
…er-errors

Use non-2015 edition paths in tests that do not test for their resolution

This allows for testing these tests on editions other than 2015

Follow up to rust-lang#141888
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jun 4, 2025
@chenyukang
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Jun 4, 2025

📌 Commit 8e285fc has been approved by chenyukang

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2025
@bors
Copy link
Collaborator

bors commented Jun 4, 2025

⌛ Testing commit 8e285fc with merge d13e543...

bors added a commit that referenced this pull request Jun 4, 2025
Rollup of 6 pull requests

Successful merges:

 - #141250 (add s390x z17 target features)
 - #141570 (Fix incorrect eq_unspanned in TokenStream)
 - #141893 (remove `f16: From<u16>`)
 - #141924 (Lightly tweak docs for BTree{Map,Set}::extract_if)
 - #141959 (Add more missing 2015 edition directives)
 - #141960 (Use non-2015 edition paths in tests that do not test for their resolution)

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

The job i686-msvc-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
test result: FAILED. 18804 passed; 1 failed; 391 ignored; 0 measured; 21 filtered out; finished in 1247.17s

Some tests failed in compiletest suite=ui mode=ui host=i686-pc-windows-msvc target=i686-pc-windows-msvc
Build completed unsuccessfully in 1:38:19
make: *** [Makefile:112: ci-msvc-py] Error 1
  local time: Wed Jun  4 04:25:21 CUT 2025
  network time: Wed, 04 Jun 2025 04:25:21 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

@bors
Copy link
Collaborator

bors commented Jun 4, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 4, 2025
@chenyukang chenyukang closed this Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants