Skip to content

Allow PR builds to read sccache entries from S3 #141948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Allow PR builds to read sccache entries from S3 #141948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,8 @@ jobs:
env:
AWS_ACCESS_KEY_ID: ${{ secrets.CACHES_AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.CACHES_AWS_SECRET_ACCESS_KEY }}
# Allow reading (but not writing) sccache on PR builds
SCCACHE_S3_NO_CREDENTIALS: ${{ (needs.calculate_matrix.outputs.run_type == 'pr' && '1') || '0' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't we already setting this in

rust/src/ci/docker/run.sh

Line 242 in b17dba4

args="$args --env SCCACHE_S3_NO_CREDENTIALS=1"
?

If there's a reason why we need to set it also here, feel free to r=me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL. I was thinking to myself that this all sounded familiar. I was checking some jobs and the cache didn't have any hits, but now I checked the rest and there were some hits, so I just checked it wrong before 🤦

This PR would also make it work for non-Linux hosts, but we don't have those on PR builds anyway.

Good find!


- name: create github artifacts
run: src/ci/scripts/create-doc-artifacts.sh
Expand Down
Loading