Skip to content

Fix create-docs-artifacts.sh with new bors #141910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jun 2, 2025

The slashes in the branch name (automation/bors/try) were causing issues for this script (https://github.com/rust-lang/rust/actions/runs/15391908130/job/43303193243).

r? @marcoieni

try-job: mingw-check*

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 2, 2025
@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 2, 2025

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 2, 2025

⌛ Trying commit ec9e560 with merge 756b43b

rust-bors bot added a commit that referenced this pull request Jun 2, 2025
Fix `create-docs-artifacts.sh` with new bors

The slashes in the branch name (`automation/bors/try`) were causing issues for this script (https://github.com/rust-lang/rust/actions/runs/15391908130/job/43303193243).

r? `@marcoieni`

try-job: `mingw-check*`
@marcoieni
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 2, 2025

📌 Commit ec9e560 has been approved by marcoieni

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2025
@rust-bors
Copy link

rust-bors bot commented Jun 2, 2025

☀️ Try build successful (CI)
Build commit: 756b43b (756b43b2e2aab5782e584d0459aedcd7aabc5bf6)

@workingjubilee
Copy link
Member

@bors rollup=iffy

@bors
Copy link
Collaborator

bors commented Jun 7, 2025

⌛ Testing commit ec9e560 with merge 1dc9ae6...

@bors
Copy link
Collaborator

bors commented Jun 7, 2025

☀️ Test successful - checks-actions
Approved by: marcoieni
Pushing 1dc9ae6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 7, 2025
@bors bors merged commit 1dc9ae6 into rust-lang:master Jun 7, 2025
11 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 7, 2025
Copy link
Contributor

github-actions bot commented Jun 7, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 775e0c8 (parent) -> 1dc9ae6 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 1dc9ae6d104205f194d84643d13fd01904a0010d --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-1: 8216.9s -> 6687.6s (-18.6%)
  2. mingw-check-1: 1922.6s -> 1634.2s (-15.0%)
  3. dist-apple-various: 6234.9s -> 7117.2s (14.2%)
  4. x86_64-rust-for-linux: 2944.7s -> 2541.8s (-13.7%)
  5. x86_64-gnu-debug: 5964.9s -> 5205.6s (-12.7%)
  6. dist-aarch64-linux: 5637.1s -> 6329.2s (12.3%)
  7. aarch64-apple: 4761.6s -> 4204.2s (-11.7%)
  8. i686-gnu-2: 5962.7s -> 5349.4s (-10.3%)
  9. dist-x86_64-apple: 9316.2s -> 8424.6s (-9.6%)
  10. armhf-gnu: 4825.0s -> 4377.3s (-9.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@Kobzol Kobzol deleted the new-bors-try-branch-name-doc branch June 7, 2025 06:52
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1dc9ae6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.1%, secondary 4.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.1% [1.1%, 1.1%] 1
Regressions ❌
(secondary)
4.8% [4.8%, 4.8%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.1% [1.1%, 1.1%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 752.833s -> 753.755s (0.12%)
Artifact size: 372.46 MiB -> 372.47 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants