Remove check_mod_loops query and run the checks per-body instead

[oli-obk]

This analysis is older than my first rustc contribution I believe. It was never querified. Ideally we'd merge it into the analysis happening within typeck anyway (typeck just uses span_delayed_bug instead of erroring), but I didn't want to do that within this PR that also moves things around and subtly changes diagnostic ordering.

[rustbot]

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[oli-obk]

@bors try @rust-timer queue

[oli-obk]

@bors2 try @rust-timer queue

[bors]

⌛ Trying commit 12e39f2 with merge 4969ee0...

[rust-bors]

⌛ Trying commit 12e39f2 with merge 70deff4…

[rust-bors]

☀️ Try build successful (CI)
Build commit: 70deff4 (70deff44501588bf26b8650f6e7b1b9c354fd45a)

[rust-timer]

Finished benchmarking commit (70deff4): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.6%	[-1.2%, -0.2%]	14
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -1.2%, secondary -0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.1%	[0.4%, 3.2%]	8
Improvements ✅ (primary)	-1.2%	[-1.2%, -1.2%]	1
Improvements ✅ (secondary)	-1.9%	[-6.6%, -0.7%]	7
All ❌✅ (primary)	-1.2%	[-1.2%, -1.2%]	1

Cycles

Results (secondary -0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.4%, 1.4%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.1%	[-2.8%, -0.4%]	11
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 774.333s -> 774.617s (0.04%)
Artifact size: 372.28 MiB -> 371.80 MiB (-0.13%)

[nnethercote]

@bors r+

[bors]

📌 Commit d718532 has been approved by nnethercote

It is now in the queue for this repository.

[bors]

☔ The latest upstream changes (presumably #141774) made this pull request unmergeable. Please resolve the merge conflicts.

[oli-obk]

@bors r=nnethercote

[bors]

📌 Commit 7f4093e has been approved by nnethercote

It is now in the queue for this repository.

[fmease]

@bors p=6 move it above the next rollup