Skip to content

FIXME(-Znext-solver) triage #141763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

FIXME(-Znext-solver) triage #141763

merged 1 commit into from
Jun 11, 2025

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented May 30, 2025

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels May 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 30, 2025

HIR ty lowering was modified

cc @fmease

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@compiler-errors
Copy link
Member

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 30, 2025
bors added a commit that referenced this pull request May 30, 2025
`FIXME(-Znext-solver)` triage

r? `@BoxyUwU`
@bors
Copy link
Collaborator

bors commented May 30, 2025

⌛ Trying commit 42adee0 with merge 19b8438...

@bors
Copy link
Collaborator

bors commented May 30, 2025

☀️ Try build successful - checks-actions
Build commit: 19b8438 (19b8438bbbb735b85f6640375c38a81c802f53cf)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (19b8438): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.1% [-1.5%, -0.8%] 9
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -3.4%, secondary -0.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.3% [0.4%, 4.6%] 6
Improvements ✅
(primary)
-3.4% [-3.4%, -3.4%] 1
Improvements ✅
(secondary)
-1.5% [-3.6%, -0.4%] 15
All ❌✅ (primary) -3.4% [-3.4%, -3.4%] 1

Cycles

Results (secondary 0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.8% [0.4%, 2.2%] 11
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.9% [-1.2%, -0.5%] 4
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: missing data
Artifact size: 370.26 MiB -> 370.27 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 31, 2025
@rust-log-analyzer

This comment has been minimized.

Co-authored-by: Michael Goulet <michael@errs.io>
@lcnr
Copy link
Contributor Author

lcnr commented Jun 3, 2025

This MIRI failure looks spurious, first time i've seen it so let's ignore it for now

@BoxyUwU
Copy link
Member

BoxyUwU commented Jun 11, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 11, 2025

📌 Commit 7dac755 has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2025
@bors
Copy link
Collaborator

bors commented Jun 11, 2025

⌛ Testing commit 7dac755 with merge bdb04d6...

@bors
Copy link
Collaborator

bors commented Jun 11, 2025

☀️ Test successful - checks-actions
Approved by: BoxyUwU
Pushing bdb04d6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 11, 2025
@bors bors merged commit bdb04d6 into rust-lang:master Jun 11, 2025
11 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 11, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0a39445 (parent) -> bdb04d6 (this PR)

Test differences

Show 14 test diffs

14 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard bdb04d6c4fff0970bc2f1fad775bec807d9470ee --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-apple: 13442.3s -> 7841.6s (-41.7%)
  2. test-various: 4332.8s -> 5025.7s (16.0%)
  3. i686-gnu-1: 7210.6s -> 8294.9s (15.0%)
  4. aarch64-apple: 4688.6s -> 4001.0s (-14.7%)
  5. mingw-check-1: 1611.3s -> 1834.2s (13.8%)
  6. dist-apple-various: 7178.1s -> 6205.4s (-13.6%)
  7. i686-gnu-2: 5378.4s -> 6065.1s (12.8%)
  8. x86_64-gnu: 6726.6s -> 7558.2s (12.4%)
  9. x86_64-apple-1: 7354.5s -> 8258.0s (12.3%)
  10. dist-sparcv9-solaris: 5263.7s -> 5811.4s (10.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@lcnr lcnr deleted the fixme-gamer branch June 11, 2025 15:03
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bdb04d6): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.4% [-0.6%, -0.3%] 2
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 2.3%, secondary 2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.3% [1.0%, 5.5%] 24
Regressions ❌
(secondary)
2.7% [0.7%, 9.9%] 84
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.3% [1.0%, 5.5%] 24

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 754.356s -> 755.487s (0.15%)
Artifact size: 372.07 MiB -> 372.14 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants