Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
3d50334
Add ignore value suggestion in closure body
chenyukang Jan 16, 2025
8cddffb
Update compiler/rustc_hir_typeck/src/fn_ctxt/suggestions.rs
chenyukang Jan 17, 2025
d6d9c2e
Update compiler/rustc_hir_typeck/src/fn_ctxt/suggestions.rs
chenyukang Jan 17, 2025
774ab46
code cleanup and do not suggest for external macro except we get bett…
chenyukang Jan 17, 2025
2d5e80b
Handle regions equivalent to 'static in non_local_bounds
matthewjasper Apr 10, 2025
c57ef29
Add unit tests for minimal_scc_representative
matthewjasper Apr 14, 2025
1d9d30f
Consistently use the DiagCtxtHandle of HirTyLowerer instead of the on…
fmease Apr 22, 2025
5fdc0de
Eliminate unnecessary parameter
fmease Apr 22, 2025
3fd047d
Name methods pertaining to HIR ty lowering of paths more appropriately
fmease Apr 23, 2025
bda903e
Introduce Boolean type `PermitVariants` for legibility
fmease Apr 23, 2025
7cd1da4
Rename and move several error reporting methods
fmease Apr 23, 2025
9e18329
Factor out `resolve_type_relative_path`
fmease Apr 23, 2025
8c37c8c
Preserve generic args in suggestions for ambiguous associated items
fmease Apr 23, 2025
c9b6ccc
Switch library rustc_unimplemented to use `Self` and `This`
mejrs May 17, 2025
9ffd0bf
do away with `_Self` and `TraitName` and check generic params for rus…
mejrs May 17, 2025
6555ef7
Querify coroutine_hidden_types
compiler-errors May 20, 2025
f60bab4
Don't allow repeat expr count inference side effects to propagate
BoxyUwU Apr 8, 2025
52f2c45
Properly test whether repeat expr checks are pre/post integer fallback
BoxyUwU Apr 10, 2025
77a2fc6
GAI logic on stable too
BoxyUwU Apr 10, 2025
508a9f0
Check for element being `const` before resolving repeat count
BoxyUwU Apr 10, 2025
4316259
Anon consts cant appear as repeat expr elements
BoxyUwU Apr 14, 2025
8373bb1
use uX::from instead of _ as uX in non - const contexts
bend-n Apr 29, 2025
cc10370
Reviews
BoxyUwU Apr 14, 2025
3529341
Rollup merge of #135562 - chenyukang:yukang-fix-128561, r=compiler-er…
matthiaskrgr May 22, 2025
4c6aee5
Rollup merge of #139635 - BoxyUwU:no_order_dependent_copy_checks, r=lcnr
matthiaskrgr May 22, 2025
706dc70
Rollup merge of #139668 - matthewjasper:upper-bound-fix, r=compiler-e…
matthiaskrgr May 22, 2025
3216098
Rollup merge of #140218 - fmease:hirtylo-clean-up-path-low, r=compile…
matthiaskrgr May 22, 2025
bc6804d
Rollup merge of #140435 - bend-n:use_ux_from_instead_of_bool_as_ux_un…
matthiaskrgr May 22, 2025
c385715
Rollup merge of #141130 - mejrs:use_self, r=compiler-errors
matthiaskrgr May 22, 2025
8c25082
Rollup merge of #141286 - compiler-errors:querify-coroutine, r=oli-obk
matthiaskrgr May 22, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update compiler/rustc_hir_typeck/src/fn_ctxt/suggestions.rs
Co-authored-by: Esteban Kuber <estebank@users.noreply.github.com>
  • Loading branch information
chenyukang and estebank committed Feb 22, 2025
commit 8cddffb74ef7fa75767c710e9f85bd4389159adb
2 changes: 1 addition & 1 deletion compiler/rustc_hir_typeck/src/fn_ctxt/suggestions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -793,7 +793,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
ExprKind::Path(..) | ExprKind::Lit(_) if parent_is_closure => {
err.span_suggestion(
expression.span.shrink_to_lo(),
"consider ignore the value here",
"consider ignoring the value",
"_ = ",
if in_external_macro(self.tcx.sess, expression.span) {
Applicability::MaybeIncorrect
Expand Down