Rename graph::implementation::Graph to LinkedGraph
#140692
Open
+39
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
rustbot
added
A-query-system
|
I did also look into removing the two existing uses of this old graph type, but doing so was sufficiently non-trivial that it doesn't turn out to be an easy win. |
This comment has been minimized.
This comment has been minimized.
wesleywiser
approved these changes
May 6, 2025
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 6, 2025
Rename `graph::implementation::Graph` to `LinkedGraph` One of the more confusing parts of the `rustc_data_structures::graph` module is this mysteriously-named “Graph” type, which turns out to be an older standalone graph implementation that predates the traits used by the rest of the graph module. This graph type is still used in a couple of places (for reporting certain lifetime errors, and by certain debugging/test-only checks of the query dependency graph), but hasn't had much attention in years. This PR renames that old graph type from `implementation::Graph` to `linked_graph::LinkedGraph` to give it a more distinct identity (and make existing uses easier to find), and adds some notes to gently discourage any further use in new code. No functional change.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2025
…llaumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#136183 (Update iterator.rs to use arrays by value) - rust-lang#139966 (coverage: Only merge adjacent coverage spans) - rust-lang#140692 (Rename `graph::implementation::Graph` to `LinkedGraph`) - rust-lang#140703 (Handle PR not found in post-merge workflow) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the more confusing parts of the
rustc_data_structures::graphmodule is this mysteriously-named “Graph” type, which turns out to be an older standalone graph implementation that predates the traits used by the rest of the graph module.This graph type is still used in a couple of places (for reporting certain lifetime errors, and by certain debugging/test-only checks of the query dependency graph), but hasn't had much attention in years.
This PR renames that old graph type from
implementation::Graphtolinked_graph::LinkedGraphto give it a more distinct identity (and make existing uses easier to find), and adds some notes to gently discourage any further use in new code.No functional change.