Skip to content

wf: emit projection goal for aliases #140558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

wf: emit projection goal for aliases #140558

wants to merge 2 commits into from
+425 −132

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented May 1, 2025 •
edited
Loading

To check that their normalization succeeds in the current environment. This eagerly detects ambiguous and diverging aliases.

Fixes #102252, fixes #126268 by removing the assertion in min_specialization.rs.

r? @compiler-errors

@lcnr
wf: emit projection goal for aliases
283c81f 
To check that their normalization succeeds in the current environment.
This eagerly detects ambiguous and diverging aliases.
@lcnr
Copy link
Contributor Author

lcnr commented May 1, 2025

@bors try

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 1, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 1, 2025

changes to inspect_obligations.rs

cc @compiler-errors, @lcnr

changes to the core type system

cc @compiler-errors, @lcnr

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 1, 2025
lcnr
lcnr commented May 1, 2025
View reviewed changes
tests/ui/infinite/type-param-default-with-diverging-assoc-type.rs
type Diverges<D: Trait> = D::Diverges<D>;
}

struct Bar<T: ?Sized = <u8 as Trait>::Diverges<u8>>(Box<T>);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there are no where-bounds on T, we never normalized the parameter default with the old solver. This is a breaking change

bors added a commit to rust-lang-ci/rust that referenced this pull request May 1, 2025
@bors
Auto merge of rust-lang#140558 - lcnr:wf-emit-projection, r=<try>
bf5ff66 
wf: emit projection goal for aliases

To check that their normalization succeeds in the current environment. This eagerly detects ambiguous and diverging aliases.

r? `@compiler-errors`
@bors
Copy link
Collaborator

bors commented May 1, 2025

⌛ Trying commit 283c81f with merge bf5ff66...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented May 1, 2025

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@lcnr
Copy link
Contributor Author

lcnr commented May 1, 2025

@craterbot check

@craterbot
Copy link
Collaborator

🚨 Error: missing start toolchain

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@lcnr
Copy link
Contributor Author

lcnr commented May 1, 2025

@craterbot check end=try#bf5ff6675cf10ce009ac02007b064a7cfc4509ac

@craterbot
Copy link
Collaborator

🚨 Error: missing start toolchain

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@lcnr
Copy link
Contributor Author

lcnr commented May 1, 2025

@craterbot run start=master#3350c1eb3fd8fe1bee1ed4c76944d707bd256876 end=try#bf5ff6675cf10ce009ac02007b064a7cfc4509ac mode=check

@craterbot
Copy link
Collaborator

🚨 Error: failed to parse the command

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@lcnr
Copy link
Contributor Author

lcnr commented May 1, 2025

@craterbot check start=master#3350c1eb3fd8fe1bee1ed4c76944d707bd256876 end=try#bf5ff6675cf10ce009ac02007b064a7cfc4509ac

@craterbot
Copy link
Collaborator

👌 Experiment pr-140558 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2025
@bors
Copy link
Collaborator

bors commented May 4, 2025

☔ The latest upstream changes (presumably #140549) made this pull request unmergeable. Please resolve the merge conflicts.

@craterbot
Copy link
Collaborator

🚧 Experiment pr-140558 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-140558 is completed!
📊 7 regressed and 6 fixed (624228 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels May 5, 2025
@compiler-errors compiler-errors added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. T-types Relevant to the types team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-types Relevant to the types team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
6 participants
@lcnr @rustbot @bors @rust-log-analyzer @craterbot @compiler-errors