Add functions pop_char and shift_char to StrBuf #14052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| let popped_char = self.as_slice().char_range_at_reverse(len).ch; | ||
| unsafe { | ||
| self.vec.set_len(len - popped_char.len_utf8_bytes()); |
There was a problem hiding this comment.
The CharRange's next field contains the index that the char starts at. You should just reuse it instead of recalculating the character length.
let char_range = self.as_slice().char_range_at_reverse(len);
unsafe {
self.vec.set_len(char_range.next);
}
Some(char_range.ch)
|
This looks great @dylanbraithwaite, thanks! With a rebase I think this is good to go. Also, feel free to ping the PR when you update it, sadly github doesn't send out notifications for updated PRs. |
…ppropriate unit tests, using the same test case as push_char. Changed StrBuf.shift_byte() that it no longer reallocates the buffer by just calling Vec.shift(); Added warning to shift_char()'s docs about it having to copy the whole buffer, as per the docs for Vec.shift().
|
I've squashed the commits and I think I've managed to rebase it against master. I think this is right? |
bors
added a commit
that referenced
this pull request
May 13, 2014
…lexcrichton Added functions pop_char and shift_char to StrBuf along with unit tests, using the same test cases as push_char.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functions pop_char and shift_char to StrBuf along with unit tests, using the same test cases as push_char.