Match on lang item kind instead of using an if/else chain #140386

oli-obk · 2025-04-28T09:09:12Z

Similar to how the new solver does this. Just noticed while I was adding a new entry to the chain 😆

oli-obk · 2025-04-28T09:09:21Z

@bors try @rust-timer queue

…try> Match on lang item kind instead of using an if/else chain r? `@ghost`

bors · 2025-04-28T09:10:44Z

⌛ Trying commit 7454d4c with merge 4ef08a1...

bors · 2025-04-28T11:20:38Z

☀️ Try build successful - checks-actions
Build commit: 4ef08a1 (4ef08a1befdf4932d9a8347d7a318b04930aa148)

Kobzol · 2025-04-28T11:28:18Z

Could also make sense to order these by frequency of occurrence, although PGO might already do that.

rust-timer · 2025-04-28T12:50:35Z

Finished benchmarking commit (4ef08a1): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.8%, -0.2%]	38
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.4%	[-0.8%, -0.2%]	38

Max RSS (memory usage)

Results (primary 0.9%, secondary 3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.4%, 3.1%]	16
Regressions ❌ (secondary)	3.0%	[2.8%, 3.2%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.9%	[0.4%, 3.1%]	16

Cycles

Results (primary -0.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.7%, -0.5%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.6%	[-0.7%, -0.5%]	3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 761.588s -> 762.112s (0.07%)
Artifact size: 365.21 MiB -> 365.01 MiB (-0.05%)

oli-obk · 2025-04-28T13:38:40Z

@bors try @rust-timer queue

bors · 2025-04-28T13:39:50Z

⌛ Trying commit 7d3e707 with merge 2658a39...

…try> Match on lang item kind instead of using an if/else chain r? `@ghost`

compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs

bors · 2025-04-28T15:46:39Z

☀️ Try build successful - checks-actions
Build commit: 2658a39 (2658a39b26bea05b2383c33dce1cbcd22491e4cf)

rust-timer · 2025-04-28T18:46:49Z

Finished benchmarking commit (2658a39): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.9%, 2.9%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.8%, -0.2%]	36
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-0.8%, 2.9%]	37

Max RSS (memory usage)

Results (primary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.5%, 0.9%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.6%, -0.6%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-0.6%, 0.9%]	4

Cycles

Results (primary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.8%	[0.5%, 3.1%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.7%, -0.5%]	5
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-0.7%, 3.1%]	7

Binary size

Results (primary 1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.1%	[1.1%, 1.1%]	1

Bootstrap: 761.378s -> 762.587s (0.16%)
Artifact size: 365.18 MiB -> 365.02 MiB (-0.04%)

…try> Match on lang item kind instead of using an if/else chain Similar to how the new solver does this. Just noticed while I was adding a new entry to the chain 😆

bors · 2025-04-29T06:54:25Z

⌛ Trying commit 03c05c9 with merge d1eb1a6...

bors · 2025-04-29T09:02:21Z

☀️ Try build successful - checks-actions
Build commit: d1eb1a6 (d1eb1a60485bcf3be32e02227a450e45090873a9)

rust-timer · 2025-04-29T14:12:15Z

Finished benchmarking commit (d1eb1a6): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.5%, 0.5%]	2
Improvements ✅ (primary)	-0.4%	[-0.8%, -0.2%]	39
Improvements ✅ (secondary)	-0.3%	[-0.4%, -0.2%]	3
All ❌✅ (primary)	-0.4%	[-0.8%, -0.2%]	39

Max RSS (memory usage)

Results (primary -0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.4%, 0.7%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-2.2%, -0.5%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.4%	[-2.2%, 0.7%]	7

Cycles

Results (primary -0.2%, secondary -2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.6%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.6%, -0.6%]	3
Improvements ✅ (secondary)	-2.2%	[-2.5%, -1.8%]	4
All ❌✅ (primary)	-0.2%	[-0.6%, 0.6%]	5

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 764.09s -> 764.031s (-0.01%)
Artifact size: 365.39 MiB -> 365.21 MiB (-0.05%)

compiler-errors · 2025-05-21T09:01:25Z

gamer

@bors r+

bors · 2025-05-21T09:01:28Z

📌 Commit 03c05c9 has been approved by compiler-errors

It is now in the queue for this repository.

…ompiler-errors Match on lang item kind instead of using an if/else chain Similar to how the new solver does this. Just noticed while I was adding a new entry to the chain 😆

bors · 2025-05-21T09:25:06Z

⌛ Testing commit 03c05c9 with merge 3161da6...

rust-log-analyzer · 2025-05-21T10:17:09Z

The job dist-powerpc64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] rustc_query_impl test:false 121.768
   Compiling rustc_driver v0.0.0 (/checkout/compiler/rustc_driver)
error: linking with `powerpc64-unknown-linux-gnu-gcc` failed: exit status: 1
  |
  = note:  "powerpc64-unknown-linux-gnu-gcc" "-Wl,--version-script=/tmp/rustc7VisJE/list" "-Wl,--no-undefined-version" "-m64" "/tmp/rustc7VisJE/symbols.o" "<1 object files omitted>" "<sysroot>-rustc/powerpc64-unknown-linux-gnu/release/deps/rustc_driver-7a35d7a5cc806d1e.02g18rrnbzn60xukki8cibahe.rcgu.rmeta" "<1 object files omitted>" "-Wl,--as-needed" "-Wl,-Bstatic" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/powerpc64-unknown-linux-gnu/release/deps/{librustc_driver_impl-7e54eb5f8d91be52.rlib,libctrlc-645f888f86a6d891.rlib,libnix-22013fbf41c1cf7a.rlib,librustc_log-1bdcc489b9522c67.rlib,libtracing_tree-dc0021399f23ee36.rlib,libtracing_log-9b2fde8f8e5ed6fe.rlib,libnu_ansi_term-b4cdff8dcf14636e.rlib,libtracing_subscriber-81f91f41eb414769.rlib,libnu_ansi_term-094b19cd917e91c0.rlib,liboverload-72c3c7ba43b35768.rlib,libsharded_slab-b5d6e063e95cc7d8.rlib,liblazy_static-6a950569675635fa.rlib,libmatchers-5b83f02fd0346115.rlib,libregex_automata-a3088a9ddbcb08ca.rlib,libregex_syntax-e1cd02f14bfeaad0.rlib,libthread_local-a403df7620a8feb5.rlib,libjiff-4ce228702d50f90d.rlib,libstable_mir-46c6cadd6bb812ef.rlib,librustc_smir-699da390150a909d.rlib,librustc_interface-13f2661f38303ede.rlib,librustc_codegen_llvm-1ae27911e8b03f6f.rlib,librustc_llvm-7e1fee925710d393.rlib,librustc_sanitizers-5abdb2bfe39ffdd2.rlib,librustc_hir_typeck-5b40f048c41bfeba.rlib,librustc_hir_analysis-30e62066d224a98d.rlib,librustc_monomorphize-a9306ceea917b183.rlib,librustc_mir_transform-4c91e7658b127764.rlib,librustc_mir_build-cbae89246c9c1677.rlib,librustc_pattern_analysis-00611c19d5d2c9de.rlib,librustc_borrowck-46d0e0733a2c6d54.rlib,librustc_traits-7162a89ff6b15a3e.rlib,librustc_const_eval-9127359b4fc63274.rlib,librustc_mir_dataflow-6891102a6bd7a988.rlib,librustc_builtin_macros-3fa8fd90e920110a.rlib,librustc_resolve-a600e77f96ba9820.rlib,libpulldown_cmark-04947de2fb8b551f.rlib,libunicase-9782330ffd9794fd.rlib,libpulldown_cmark_escape-09bbc6bc454613b0.rlib,librustc_passes-97f6b70e9b6aa5d8.rlib,librustc_ast_lowering-c8b364c2043f7387.rlib,librustc_privacy-a5e38905660af724.rlib,librustc_ty_utils-4066029d94b5196d.rlib,librustc_lint-283d6824e36ea693.rlib,libunicode_security-958501725b19e3eb.rlib,libunicode_script-a8ca0b166b368145.rlib,librustc_query_impl-0291a0ea49a2ab44.rlib,librustc_codegen_ssa-4f151fecb4798d7a.rlib,libwasm_encoder-251db596a1ec423d.rlib,libleb128-f4bf6b7354f39d3d.rlib,libthorin-b523c522090b1551.rlib,libgimli-0c91f012d709630d.rlib,libfallible_iterator-35e78cc4f82eb1df.rlib,libbstr-8a1c4c9ed2bbf25c.rlib,librustc_trait_selection-e2fe2364ee8cc4a6.rlib,librustc_next_trait_solver-dc25d46e32c5ca80.rlib,librustc_parse_format-272664cddc50bb39.rlib,librustc_transmute-658f56fd2f94745b.rlib,librustc_infer-0d169b711b640249.rlib,librustc_incremental-fb66c887c4f9224b.rlib,librustc_symbol_mangling-b9e0dba10a54c478.rlib,librustc_demangle-8ca814943935548e.rlib,libpunycode-fc7488a3b170f566.rlib,libpathdiff-39b2f237cd2683ec.rlib,librustc_metadata-d98a430a02ec6844.rlib,liblibloading-8f38f03be5c24999.rlib,librustc_expand-a37e9a88afde9f76.rlib,librustc_ast_passes-254f36a9693d2a11.rlib,librustc_parse-99fb696634e1abfd.rlib,libunicode_normalization-438e69fd99796183.rlib,libtinyvec-bd5c62fec0babb35.rlib,libtinyvec_macros-105e861ca77729dd.rlib,librustc_attr_parsing-677767e845cf50a2.rlib}.rlib" "<sysroot>/lib/rustlib/powerpc64-unknown-linux-gnu/lib/{libproc_macro-*,librustc_literal_escaper-*,librustc_std_workspace_std-*}.rlib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/powerpc64-unknown-linux-gnu/release/deps/{libregex-a764a3f24dfd3304.rlib,libregex_automata-dbe18fd04e38e066.rlib,libaho_corasick-b2ee39ac65cc1ec5.rlib,libregex_syntax-334c30cbd7af7408.rlib,libcc-013f65103352130a.rlib,libshlex-c592d665fd0271c0.rlib,libar_archive_writer-1043d9f3df08f7be.rlib,librustc_middle-fc84ae534d397fac.rlib,librustc_apfloat-a3f792d7d25179a7.rlib,libgsgdt-19f7aa4a46b2995f.rlib,libpolonius_engine-3a41e44bfb462f00.rlib,libdatafrog-0de271de1bf92584.rlib,librustc_query_system-a6ce07088cc23ee3.rlib,librustc_session-2f2997eaca05f1ce.rlib,libgetopts-d26cca48124c0b9a.rlib,libunicode_width-b4a7408d5cc0d8dd.rlib,librustc_feature-d65e730a20511560.rlib,librustc_hir_pretty-6798b19fa96e41e8.rlib,librustc_errors-9033067ea364c91c.rlib,libtermize-aae52745c9edea0c.rlib,librustc_error_codes-dad742a2466217c0.rlib,librustc_type_ir-d4e315c327b4ddda.rlib,libannotate_snippets-247ad19c27305e1b.rlib,libanstyle-1c7ad22e1e538db7.rlib,libtermcolor-060ed34033a5bb6b.rlib,librustc_lint_defs-33b00d40c624fd6c.rlib,librustc_error_messages-34c2da4665f458c5.rlib,librustc_baked_icu_data-401cd1cd0765a08f.rlib,libicu_list-832b97ae480971c1.rlib,libicu_list_data-9f957bba5a27b481.rlib,libregex_automata-ef9f499b9c0b152b.rlib,libicu_provider_adapters-c4b1276879851be8.rlib,libicu_locid_transform-f22e1b2dc6d30176.rlib,libicu_locid_transform_data-ab9a0853647f458a.rlib,libicu_provider-e95cf8582a94697a.rlib,libicu_locid-5e4b4c0ea3d5d8e0.rlib,liblitemap-a5fca89e946f3153.rlib,libtinystr-cf024bff93d0a1a8.rlib,libzerovec-e839875dd049720e.rlib,libwriteable-50f1b068d9c37ff4.rlib,libyoke-35f376d3de6ef6f1.rlib,libzerofrom-849a83f6abeb1864.rlib,libfluent_bundle-167afc71e09f5e8b.rlib,libfluent_langneg-c49d245af78dd863.rlib,libintl_pluralrules-c184d096cc70d2c1.rlib,libself_cell-abebcc8aac1f6757.rlib,libself_cell-b9518ef316f1310a.rlib,libintl_memoizer-ce48c54d03177bbd.rlib,libtype_map-6a5f3ea5d06c39c8.rlib,libunic_langid-55c077864228bf92.rlib,libunic_langid_macros-d759504c1fa16e76.rlib,libunic_langid_impl-723e3f9b0523fb0a.rlib,libtinystr-d194a092805c421b.rlib,libfluent_syntax-a3d505520cf1ed0f.rlib,libthiserror-f9c2b479a8f937b2.rlib,librustc_hir-a28428c53f0128a5.rlib,libodht-8046021b83dfaeda.rlib,librustc_target-f929fc36511669ee.rlib,libobject-6491321d3d558430.rlib,libruzstd-50e28c17e8ecc4d4.rlib,libtwox_hash-75035b633e80c50b.rlib,librand-b310fac33e95fbb9.rlib,librand_chacha-4b672747a9c97b01.rlib,librand_core-a2c45e109964ca27.rlib,libgetrandom-d97624c105f3c2c0.rlib,libstatic_assertions-a504f8d7046dfb64.rlib,libflate2-c9cd4f3c589a9261.rlib,libminiz_oxide-ee10c22ba3f3811f.rlib,libadler2-211845ee4e7cfe04.rlib,libcrc32fast-abd22d5e6dbff690.rlib,libwasmparser-2b5c086c29d2a1b2.rlib,librustc_fs_util-a6758cdd8a9892f7.rlib,libserde_json-ddd65b49af5ad9b8.rlib,libryu-447ce492256895e6.rlib,libserde-49ae361f1c81c90d.rlib,librustc_attr_data_structures-1d01bf8069b4ff8a.rlib,librustc_ast_pretty-f8f8383b2c172749.rlib,librustc_lexer-29caaefcc97df7e6.rlib,libunicode_xid-64e96582cf0f24b5.rlib,libunicode_properties-61d826979b831fb8.rlib,libitertools-bbf5e0783d2cd03d.rlib,librustc_abi-48950f63893b107c.rlib,librand_xoshiro-6ee7cd4c3ff31c44.rlib,librand-e1e02993f50eb49e.rlib,librand_chacha-fb9049cdbd43aa59.rlib,libppv_lite86-1b53d72445708a84.rlib,libzerocopy-25043e71ef3517bc.rlib,librand_core-8efdb6392344c15f.rlib,librustc_ast-a966cb6943affb30.rlib,libmemchr-b91260527eae3cca.rlib,librustc_ast_ir-390c91a6564d71b9.rlib,librustc_literal_escaper-e79f6c89f37a5722.rlib,librustc_span-6fb6e920eb579e6f.rlib,libunicode_width-1dde031e2ec2e75a.rlib,libblake3-8e38c3443caad775.rlib,libconstant_time_eq-c4a0d7c97426fc1c.rlib,libarrayref-3a188fcd1bd6bdf4.rlib,libitoa-a276aa0163e66b0a.rlib,libscoped_tls-91b84c5c50e15af9.rlib,libsha2-9858a703852b3179.rlib,libsha1-b4697e24cfa6281a.rlib,libmd5-82e9d9226f02d01f.rlib,libdigest-b7bad6e0d82543da.rlib,libblock_buffer-88dbfab33816bfca.rlib,libcrypto_common-26995a616d104ce3.rlib,libgeneric_array-b0cbb1c92e21e80b.rlib,libtypenum-914ae056d39e808c.rlib,librustc_data_structures-a9fed702a24a7580.rlib,libelsa-05a15b9460449278.rlib,libstable_deref_trait-d100ac0e8ead8546.rlib,librayon_core-697b762d0c62a22c.rlib,libcrossbeam_deque-f73ca993eb75d68b.rlib,libcrossbeam_epoch-883e2e2d75fa8e86.rlib,libcrossbeam_utils-01a9ba1cba490b44.rlib,libstacker-172cca14822b267b.rlib,libpsm-c485cb2781b2ba0c.rlib,libmemmap2-640bfc2a086e7ff8.rlib,librustc_arena-b51afc04cc140e95.rlib,libtempfile-929b1fc7226e9ee8.rlib,libgetrandom-6feb413e00d58d5a.rlib,libfastrand-385f8cb27b6f7617.rlib,librustix-07df230ee21d6a8c.rlib,liblinux_raw_sys-c20e93f91c50c927.rlib,libbitflags-1c4b285d0c2ce57b.rlib,liberrno-c26f88f919d8a0df.rlib,libarrayvec-8ca79b71ff507159.rlib,libeither-3b918639ed842f50.rlib,libmeasureme-39d0cd86f9606e73.rlib,librustc_hash-bade69299d7a9583.rlib,librustc_graphviz-2d29519a8b41c434.rlib,libparking_lot-560c0d7afbe98f70.rlib,libparking_lot_core-2a2dc46a01a09ae9.rlib,liblock_api-c2d355dac25f99dc.rlib,libscopeguard-f2feb4b367e067a5.rlib,libjobserver-22021a63e817cd80.rlib,liblibc-c42ca6c89797d9df.rlib,libtracing-f3f3b05601a452ed.rlib,libcfg_if-a5adfc6f43e2e341.rlib,libpin_project_lite-d42aaa9555ebf690.rlib,libtracing_core-78b768bda1452c49.rlib,libonce_cell-0297ab5383adeb14.rlib,librustc_hash-f7ba337301140439.rlib,librustc_index-7cf2655680541190.rlib,librustc_serialize-61d35f58ea27514f.rlib,libindexmap-9dc7f162d9b6525f.rlib,libhashbrown-feca8895358b116c.rlib,libfoldhash-583f93e2d7050153.rlib,libequivalent-5d0eb90d4da404dd.rlib,libthin_vec-9a9509d43fbe7ff0.rlib,librustc_hashes-508ba54e32c89b49.rlib,librustc_stable_hash-1dc90ec762743e11.rlib,libsmallvec-03edfdcaa4377fa3.rlib,libena-78c4760b9ecc8c03.rlib,liblog-0c5c1413848dc0a2.rlib}.rlib" "<sysroot>/lib/rustlib/powerpc64-unknown-linux-gnu/lib/{libstd-*,libpanic_unwind-*,libobject-*,libmemchr-*,libaddr2line-*,libgimli-*,librustc_demangle-*,libstd_detect-*,libhashbrown-*,librustc_std_workspace_alloc-*,libminiz_oxide-*,libadler2-*,libunwind-*,libcfg_if-*,liblibc-*,liballoc-*,librustc_std_workspace_core-*,libcore-*,libcompiler_builtins-*}.rlib" "-Wl,-Bdynamic" "-ldl" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-L" "/tmp/rustc7VisJE/raw-dylibs" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "<sysroot>-rustc/powerpc64-unknown-linux-gnu/release/build/psm-767bcc933e2d06a0/out" "-L" "<sysroot>-rustc/powerpc64-unknown-linux-gnu/release/build/rustc_llvm-a1af0a6705958d05/out" "-L" "/checkout/obj/build/powerpc64-unknown-linux-gnu/llvm/lib" "-L" "/x-tools/powerpc64-unknown-linux-gnu/lib/gcc/powerpc64-unknown-linux-gnu/8.5.0/../../../../powerpc64-unknown-linux-gnu/lib/../lib64" "-L" "<sysroot>/lib/rustlib/powerpc64-unknown-linux-gnu/lib" "-o" "<sysroot>-rustc/powerpc64-unknown-linux-gnu/release/deps/librustc_driver-7a35d7a5cc806d1e.so" "-shared" "-Wl,-soname=librustc_driver-7a35d7a5cc806d1e.so" "-Wl,-z,relro,-z,now" "-Wl,-O1" "-nodefaultlibs" "-Wl,-z,origin" "-Wl,-rpath,$ORIGIN/../lib"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: /x-tools/powerpc64-unknown-linux-gnu/lib/gcc/powerpc64-unknown-linux-gnu/8.5.0/../../../../powerpc64-unknown-linux-gnu/bin/ld: BFD (crosstool-NG UNKNOWN) 2.32 assertion fail /tmp/build/.build/powerpc64-unknown-linux-gnu/src/binutils/bfd/elf64-ppc.c:10251
          collect2: error: ld returned 1 exit status
          

[RUSTC-TIMING] rustc_driver test:false 19.925
error: could not compile `rustc_driver` (lib) due to 1 previous error

bors · 2025-05-21T10:17:57Z

💔 Test failed - checks-actions

oli-obk · 2025-05-21T10:18:21Z

@bors retry powerpc64-unknown-linux-gnu-gcc linker error

bors · 2025-05-21T13:31:17Z

⌛ Testing commit 03c05c9 with merge 356f2d0...

bors · 2025-05-21T16:41:48Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 356f2d0 to master...

github-actions · 2025-05-21T16:44:29Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c43786c (parent) -> 356f2d0 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 356f2d077498d0ebe5ec4f9cfef04293a2b17611 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-illumos: 5940.2s -> 8163.3s (37.4%)
aarch64-apple: 3725.1s -> 5019.2s (34.7%)
dist-apple-various: 8789.2s -> 6122.3s (-30.3%)
dist-arm-linux-musl: 6358.2s -> 8056.5s (26.7%)
dist-x86_64-musl: 7871.1s -> 9893.0s (25.7%)
dist-x86_64-freebsd: 5115.6s -> 6376.3s (24.6%)
dist-android: 2515.2s -> 3085.5s (22.7%)
dist-riscv64-linux: 5113.5s -> 6255.9s (22.3%)
dist-armhf-linux: 5274.2s -> 6380.2s (21.0%)
dist-s390x-linux: 5270.7s -> 6374.6s (20.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-05-21T18:24:02Z

Finished benchmarking commit (356f2d0): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.2%, 0.7%]	2
Regressions ❌ (secondary)	0.3%	[0.2%, 0.4%]	4
Improvements ✅ (primary)	-0.3%	[-0.7%, -0.1%]	55
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.1%]	3
All ❌✅ (primary)	-0.2%	[-0.7%, 0.7%]	57

Max RSS (memory usage)

Results (secondary 3.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[3.2%, 3.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 2.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.5%, 2.9%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.543s -> 775.51s (-0.00%)
Artifact size: 365.51 MiB -> 365.50 MiB (-0.00%)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 28, 2025

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 28, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2025

Auto merge of rust-lang#140386 - oli-obk:match-on-lang-item-kind, r=<…

4ef08a1

…try> Match on lang item kind instead of using an if/else chain r? `@ghost`

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 28, 2025

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 28, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2025

Auto merge of rust-lang#140386 - oli-obk:match-on-lang-item-kind, r=<…

2658a39

…try> Match on lang item kind instead of using an if/else chain r? `@ghost`

oli-obk marked this pull request as ready for review April 28, 2025 13:40

compiler-errors requested changes Apr 28, 2025

View reviewed changes

compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs Outdated Show resolved Hide resolved

compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs Show resolved Hide resolved

compiler-errors self-assigned this Apr 28, 2025

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Apr 28, 2025

oli-obk force-pushed the match-on-lang-item-kind branch from 7d3e707 to 6620703 Compare April 29, 2025 06:51

oli-obk added 3 commits April 29, 2025 06:52

Replace if/elseif chain with match

19fc3a1

Always check the lang item first

dd71427

Also match on the lang item in confirmation

03c05c9

oli-obk force-pushed the match-on-lang-item-kind branch from 6620703 to 03c05c9 Compare April 29, 2025 06:53

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 29, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 29, 2025

compiler-errors approved these changes May 21, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2025

oli-obk mentioned this pull request May 21, 2025

Sized Hierarchy: Part I #137944

Open

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 21, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label May 21, 2025

bors merged commit 356f2d0 into rust-lang:master May 21, 2025
7 checks passed

rustbot added this to the 1.89.0 milestone May 21, 2025

bors mentioned this pull request May 21, 2025

Add iter macro #137725

Open

Match on lang item kind instead of using an if/else chain #140386

Match on lang item kind instead of using an if/else chain #140386

Uh oh!

Conversation

oli-obk commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oli-obk commented Apr 28, 2025

Uh oh!

This comment has been minimized.

bors commented Apr 28, 2025

Uh oh!

bors commented Apr 28, 2025

Uh oh!

This comment has been minimized.

Kobzol commented Apr 28, 2025

Uh oh!

rust-timer commented Apr 28, 2025

Overall result: ✅ improvements - no action needed

Uh oh!

oli-obk commented Apr 28, 2025

Uh oh!

This comment has been minimized.

bors commented Apr 28, 2025

Uh oh!

Uh oh!

Uh oh!

bors commented Apr 28, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Apr 28, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

bors commented Apr 29, 2025

Uh oh!

bors commented Apr 29, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Apr 29, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

compiler-errors commented May 21, 2025

Uh oh!

bors commented May 21, 2025

Uh oh!

bors commented May 21, 2025

Uh oh!

rust-log-analyzer commented May 21, 2025

Uh oh!

bors commented May 21, 2025

Uh oh!

oli-obk commented May 21, 2025

Uh oh!

bors commented May 21, 2025

Uh oh!

bors commented May 21, 2025

Uh oh!

Uh oh!

github-actions bot commented May 21, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented May 21, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

Uh oh!

oli-obk commented Apr 28, 2025 •

edited

Loading