Skip to content

HIR ty lowering: Clean up & refactor the lowering of type-relative paths #140218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 23, 2025
Merged

HIR ty lowering: Clean up & refactor the lowering of type-relative paths #140218

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1d9d30f
Consistently use the DiagCtxtHandle of HirTyLowerer instead of the on…
fmease Apr 22, 2025
5fdc0de
Eliminate unnecessary parameter
fmease Apr 22, 2025
3fd047d
Name methods pertaining to HIR ty lowering of paths more appropriately
fmease Apr 23, 2025
bda903e
Introduce Boolean type `PermitVariants` for legibility
fmease Apr 23, 2025
7cd1da4
Rename and move several error reporting methods
fmease Apr 23, 2025
9e18329
Factor out `resolve_type_relative_path`
fmease Apr 23, 2025
8c37c8c
Preserve generic args in suggestions for ambiguous associated items
fmease Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Name methods pertaining to HIR ty lowering of paths more appropriately
  • Loading branch information
@fmease
fmease committed May 6, 2025
commit 3fd047d164c09cc3c0d5a8c6833e6021c5f5934e
2 changes: 1 addition & 1 deletion compiler/rustc_hir_analysis/src/collect.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ impl<'tcx> HirTyLowerer<'tcx> for ItemCtxt<'tcx> {
self.tcx.at(span).type_param_predicates((self.item_def_id, def_id, assoc_ident))
}

fn lower_assoc_shared(
fn lower_assoc_item_path(
&self,
span: Span,
item_def_id: DefId,
Expand Down
2 changes: 1 addition & 1 deletion compiler/rustc_hir_analysis/src/hir_ty_lowering/bounds.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,7 @@ impl<'tcx> dyn HirTyLowerer<'tcx> + '_ {
}

/// Perform type-dependent lookup for a *method* for return type notation.
/// This generally mirrors `<dyn HirTyLowerer>::lower_assoc_path`.
/// This generally mirrors `<dyn HirTyLowerer>::lower_type_relative_path`.
fn resolve_type_relative_return_type_notation(
&self,
qself: &'tcx hir::Ty<'tcx>,
Expand Down
Loading