Add Duration from nanos u128 #139243

omanirudh · 2025-04-02T08:48:52Z

What does this PR do?

This draft PR adds the Duration::from_nanos_u128 function to handle durations that exceed the range of u64, allowing for time spans greater than ~584 years.

Motivation

The current Duration API does not support creating durations from nanoseconds represented as u128. This addition addresses that limitation.

Tracking Issue

Fixes #139201

Details

Introduced Duration::from_nanos_u128 as a const fn similar to other functions in the file.
Ensured safety by validating the nanoseconds before using unsafe code.
To do : complete the documentation and examples for the new function.

r? @RalfJung

rustbot · 2025-04-02T08:48:56Z

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

library/core/src/time.rs

RalfJung · 2025-04-02T12:06:56Z

Thanks for taking this over!
However, this needs a libs reviewer. I just proposed the API. :)

r? libs

omanirudh · 2025-04-02T15:08:45Z

Thanks for taking this over! However, this needs a libs reviewer. I just proposed the API. :)

r? libs

Happy to take this up. noted.

library/core/src/time.rs

tgross35 · 2025-04-02T18:06:31Z

@rustbot author

rustbot · 2025-04-02T18:06:36Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

library/core/src/time.rs

…r-errors handle specialization in the new trait solver fixes rust-lang/trait-system-refactor-initiative#187 also fixes the regression in `plonky2_field` from rust-lang/trait-system-refactor-initiative#188 cc rust-lang#111994 r? ```@compiler-errors```

stall generator witness obligations: add regression test fixes rust-lang/trait-system-refactor-initiative#180 r? ```@compiler-errors```

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#139865 (Stabilize proc_macro::Span::{start,end,line,column}.) - rust-lang#140086 (If creating a temporary directory fails with permission denied then retry with backoff) - rust-lang#140216 (Document that "extern blocks must be unsafe" in Rust 2024) - rust-lang#140253 (Add XtensaAsmPrinter) - rust-lang#140272 (Improve error message for `||` (or) in let chains) - rust-lang#140305 (Track per-obligation recursion depth only if there is inference in the new solver) - rust-lang#140306 (handle specialization in the new trait solver) - rust-lang#140308 (stall generator witness obligations: add regression test) r? `@ghost` `@rustbot` modify labels: rollup

tgross35

Implementation and docs look good to me, left a few small comments about adding backticks around code types. However, this needs some tests. Could you update library/coretests/tests/time.rs to include from_nanos_u128 everywhere that from_nanos is tested? Also make sure some large values are tested, and one or two #[should_panic] tests for the overflow.

tgross35 · 2025-04-26T23:32:10Z

library/core/src/time.rs

@@ -308,6 +307,39 @@ impl Duration {
        Duration { secs, nanos: subsec_nanos }
    }

+    /// Creates a new Duration from the specified number of nanoseconds.


Suggested change

/// Creates a new Duration from the specified number of nanoseconds.

/// Creates a new `Duration` from the specified number of nanoseconds.

tgross35 · 2025-04-26T23:32:23Z

library/core/src/time.rs

+    ///
+    /// # Panics
+    ///
+    /// Panics if the given number of nanoseconds is greater than what Duration can handle,


Suggested change

/// Panics if the given number of nanoseconds is greater than what Duration can handle,

/// Panics if the given number of nanoseconds is greater than what `Duration` can handle,

tgross35 · 2025-04-26T23:32:32Z

library/core/src/time.rs

+    ///
+    /// Panics if the given number of nanoseconds is greater than what Duration can handle,
+    /// which is `(u64::MAX * NANOS_PER_SEC) + NANOS_PER_SEC - 1`
+    /// Use this function if you need to specify time greater than what can fit in u64


Suggested change

/// Use this function if you need to specify time greater than what can fit in u64

/// Use this function if you need to specify time greater than what can fit in `u64`

tgross35 · 2025-04-26T23:44:55Z

library/core/src/time.rs

@@ -1,5 +1,4 @@
 #![stable(feature = "duration_core", since = "1.25.0")]
-


Looks like a spurious removal

tgross35 · 2025-04-27T00:10:24Z

I looked into it. This PR now has just one commit. I preserved the commit messages of earlier commits though.

Also fyi - pedantically, there is no need to preserve the messages unless they are still meaningful. It's best if the message describes the contained change, it's not really useful to rust's forever history that you had "dummy commit" and "remove parentheses" at some point :)

omanirudh · 2025-04-27T08:04:02Z

I looked into it. This PR now has just one commit. I preserved the commit messages of earlier commits though.

Also fyi - pedantically, there is no need to preserve the messages unless they are still meaningful. It's best if the message describes the contained change, it's not really useful to rust's forever history that you had "dummy commit" and "remove parentheses" at some point :)

noted.

…dh/rust into nanos

tgross35 · 2025-06-09T21:03:38Z

@omanirudh are you able to do the updates to get this over the line? Mostly just test updates and a few nits.

omanirudh · 2025-06-10T03:04:41Z

Hey Trevor, thanks for bringing this to my attention. I am caught up in my day job. I need time until Thursday morning (Eastern). I would really love to do this and make my first OSS contribution. Also I am tied up so if it doesn't happen by this time. I will move on and close the pull request to keep it open for others. All of this assuming there is time until then. In case this isn't the case. Please feel free to assign this to someone more immediately available.

…

On Tue, Jun 10, 2025 at 2:34 AM Trevor Gross ***@***.***> wrote: *tgross35* left a comment (rust-lang/rust#139243) <#139243 (comment)> @omanirudh <https://github.com/omanirudh> are you able to do the updates to get this over the line? Mostly just test updates and a few nits. — Reply to this email directly, view it on GitHub <#139243 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BPJEXXJ2Y4MX6VI72O5MUCD3CXZEDAVCNFSM6AAAAAB2I6KI7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNJXGAZDSOJTGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

tgross35 · 2025-06-10T03:06:36Z

It's not a problem! This is open source, there are no deadlines 🙂 we just try to make sure changes that are pretty close to done don't fall off the map.

omanirudh · 2025-06-10T03:10:22Z

Awesome! Here's one cheer to make this happen soon.

…

On Tue, Jun 10, 2025 at 8:36 AM Trevor Gross ***@***.***> wrote: *tgross35* left a comment (rust-lang/rust#139243) <#139243 (comment)> It's not a problem! This is open source, there are no deadlines 🙂 we just try to make sure changes that are pretty close to done don't fall off the map. — Reply to this email directly, view it on GitHub <#139243 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BPJEXXOWEXYCEW77O4VZ7CT3CZDVFAVCNFSM6AAAAAB2I6KI7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNJXGU2TAOBWG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

rustbot · 2025-06-29T03:07:07Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in exhaustiveness checking

cc @Nadrieril

Some changes occurred in coverage instrumentation.

cc @Zalathar

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in match checking

cc @Nadrieril

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in match lowering

cc @Nadrieril

Some changes occurred in compiler/rustc_codegen_llvm/src/builder/autodiff.rs

cc @ZuseZ4

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

rustc_macros::diagnostics was changed

cc @davidtwco, @compiler-errors, @TaKO8Ki

Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs

cc @ZuseZ4

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

changes to the core type system

cc @compiler-errors, @lcnr

Some changes occurred in compiler/rustc_sanitizers

cc @rcvalle

These commits modify compiler targets.
(See the Target Tier Policy.)

HIR ty lowering was modified

cc @fmease

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

rustbot · 2025-06-29T03:07:10Z

⚠️ Warning ⚠️

There are username mentions (such as @user) in the commit messages of the following commits.
Please remove the mentions to avoid spamming these users.
- 0621446
There are issue links (such as #123) in the commit messages of the following commits.
Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.
- aeb6ac9
- dfc8f02
- 6be270b
- e9d374c
- c3fb102
- 0621446
- 19e44d4
- 780f95d
- d8528c6
The following commits have merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.
- 02ebca2
- 06126df
- 0621446
- 07a28ec
- 090f6a9
- 096c495
- 10732e1
- 107f04d
- 11fbbc5
- 1254559
- 1553cfa
- 1586660
- 15f8847
- 1a5bf12
- 1b9e11e
- 1ca5e4f
- 1cb9a0d
- 204e9a0
- 264249f
- 27eac4b
- 280aa4a
- 2a07f99
- 2ba3a5c
- 2d8264f
- 2fff825
- 31a72bc
- 32862fb
- 32b2428
- 394cdca
- 3c08a50
- 3c877f6
- 3cd97b6
- 4323939
- 45b5d8b
- 4bbd21b
- 4c0d38b
- 4f83a42
- 52bb2bb
- 538ae99
- 53afa97
- 54eae59
- 553600e
- 555e1d0
- 564e5cc
- 5779843
- 59191fa
- 5ae50d3
- 5c54aa7
- 5d52b37
- 5dbe271
- 60c2c34
- 610ed82
- 645d0ad
- 6bc57c6
- 6f6fa0f
- 77325f5
- 7ba71d3
- 7f27d16
- 7f6707b
- 7f69523
- 806260e
- 8089e31
- 82a87f3
- 847e3ee
- 84a921d
- 862156d
- 8868163
- 8888488
- 8bf5a8d
- 8ecaf14
- 8f2819b
- 8f42ac0
- 8f43b85
- 93c1e05
- 9471811
- 96ac7d8
- 984ef2c
- 986750d
- 99dc43b
- 9bfa31f
- 9dcb367
- 9eb0078
- a016552
- a353796
- a37f423
- a8ebfb2
- a90f31e
- ac477db
- aeb6ac9
- b03267f
- b3a0104
- b4c8b0c
- bc25dc2
- be181dd
- c02a4f0
- c046a43
- c3f811f
- c3fb102
- c43022f
- c43b82f
- c781c9a
- cac8bc3
- cb3c5d7
- cea6ba7
- d08a527
- d3508a8
- d6c1e45
- d7ea436
- dc8fe1f
- ddf0176
- df35ff6
- df9e15e
- e3e432d
- e534fad
- e970d63
- eb225e3
- ecb9775
- ed4e167
- ee7766a
- ef16755
- f2f4152
- f3641df
- f45d2bd
- f8c67c6
- fa58ce3
- fae7785
- fdaa91a
You can start a rebase with the following commands:
```
$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust.git master
$ git push --force-with-lease
```
This PR is based on an upstream commit that is 69 days old.

It's recommended to update your branch according to the rustc-dev-guide.

tgross35 · 2025-06-29T18:33:00Z

@omanirudh it looks like you wound up with bad commit history somehow. You should be able to fix this by rebasing your branch, check out https://rustc-dev-guide.rust-lang.org/git.html#rebasing

rustbot assigned tgross35 Apr 2, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 2, 2025

rustbot assigned RalfJung and unassigned tgross35 Apr 2, 2025

This comment has been minimized.

Sign in to view

madhav-madhusoodanan reviewed Apr 2, 2025

View reviewed changes

library/core/src/time.rs Show resolved Hide resolved

madhav-madhusoodanan reviewed Apr 2, 2025

View reviewed changes

library/core/src/time.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

rustbot assigned joboet and unassigned RalfJung Apr 2, 2025

tgross35 requested changes Apr 2, 2025

View reviewed changes

library/core/src/time.rs Outdated Show resolved Hide resolved

library/core/src/time.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2025

This comment has been minimized.

Sign in to view

madhav-madhusoodanan reviewed Apr 3, 2025

View reviewed changes

library/core/src/time.rs Show resolved Hide resolved

This comment has been minimized.

Sign in to view

omanirudh marked this pull request as ready for review April 10, 2025 15:53

rustbot added the has-merge-commits PR has merge commits, merge with caution. label Apr 10, 2025

matthiaskrgr and others added 3 commits April 26, 2025 07:13

Rollup merge of rust-lang#140308 - lcnr:add-ui-test, r=compiler-errors

c781c9a

stall generator witness obligations: add regression test fixes rust-lang/trait-system-refactor-initiative#180 r? ```@compiler-errors```

tgross35 requested a review from madhav-madhusoodanan April 26, 2025 23:46

tgross35 requested changes Apr 26, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2025

Merge branch 'duration-from-nanos-u128' of https://github.com/omaniru…

7f6707b

…dh/rust into nanos

Tests for from_nanos_u128 method

b7e27a4

	/// Creates a new Duration from the specified number of nanoseconds.
	/// Creates a new `Duration` from the specified number of nanoseconds.

	/// Panics if the given number of nanoseconds is greater than what Duration can handle,
	/// Panics if the given number of nanoseconds is greater than what `Duration` can handle,

	/// Use this function if you need to specify time greater than what can fit in u64
	/// Use this function if you need to specify time greater than what can fit in `u64`

		@@ -1,5 +1,4 @@
		#![stable(feature = "duration_core", since = "1.25.0")]

Add Duration from nanos u128 #139243

Are you sure you want to change the base?

Add Duration from nanos u128 #139243

Conversation

omanirudh commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Tracking Issue

Details

Uh oh!

rustbot commented Apr 2, 2025

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

This comment has been minimized.

RalfJung commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

omanirudh commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tgross35 commented Apr 2, 2025

Uh oh!

rustbot commented Apr 2, 2025

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

tgross35 left a comment

Choose a reason for hiding this comment

Uh oh!

tgross35 Apr 26, 2025

Choose a reason for hiding this comment

Uh oh!

tgross35 Apr 26, 2025

Choose a reason for hiding this comment

Uh oh!

tgross35 Apr 26, 2025

Choose a reason for hiding this comment

Uh oh!

tgross35 Apr 26, 2025

Choose a reason for hiding this comment

Uh oh!

tgross35 commented Apr 27, 2025

Uh oh!

omanirudh commented Apr 27, 2025

Uh oh!

tgross35 commented Jun 9, 2025

Uh oh!

omanirudh commented Jun 10, 2025 via email

Uh oh!

tgross35 commented Jun 10, 2025

Uh oh!

omanirudh commented Jun 10, 2025 via email

Uh oh!

rustbot commented Jun 29, 2025

Uh oh!

rustbot commented Jun 29, 2025

Uh oh!

tgross35 commented Jun 29, 2025

Uh oh!

Uh oh!

omanirudh commented Apr 2, 2025 •

edited

Loading

RalfJung commented Apr 2, 2025 •

edited

Loading

omanirudh commented Apr 2, 2025 •

edited

Loading