Add documentation for Bitv. #13836
Merged
Add documentation for Bitv. #13836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Creates an empty Bitv that holds `nbits` elements | ||
| * | ||
| * Sets each element to `init` | ||
| */ |
There was a problem hiding this comment.
Our predominant documentation style is three slashes, could you change this to that?
There was a problem hiding this comment.
Perhaps this could gain an example as well?
|
Could you rebase the two commits into one? Also feel free to ping the PR whenever you update it, sadly none of us get notifications when you do! |
|
Thanks for the tip about pinging after an update. I'm new to contributing and I try not to ping too much. I rebased the two commits into one as asked. |
bors
added a commit
that referenced
this pull request
May 7, 2014
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2023
…hanged, r=Veykril fix: consider relative offset to fake ident token in expansion for completion Fixes rust-lang#13836 When we check if the offset of fake ident token is out of bounds in the "actual expansion" (i.e. expansion without the fake ident token), we should take relative offset to it into account to match [how we'd get token after expansion](https://github.com/rust-lang/rust-analyzer/blob/f1b257f4eb4fef74b42fd7135d1cf3884e8b51c9/crates/ide-completion/src/context/analysis.rs#L53-L54).
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 26, 2024
…3836) fix rust-lang#11524 In a `no_std` environment, we can use `core::cmp::Reverse` instead of `std::cmp::Reverse`. ---- changelog: [`unnecessary_sort_by`]: correct suggestion in `no_std`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.