Skip to content

Rollup of 17 pull requests #138127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Mar 7, 2025
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
ddd04d0
Add timestamp to unstable feature usage metrics
yaahc Feb 28, 2025
056ec72
trim channel value in `get_closest_merge_commit`
onur-ozkan Mar 5, 2025
3dbf3dc
Increase the max. custom try jobs requested to `20`
Kobzol Mar 5, 2025
9c75ed2
triagebot: add `compiler_leads` ad-hoc group
jieyouxu Mar 5, 2025
376955e
feat: Remove - from xtensa targets cpu names
SergioGasquez Mar 5, 2025
c85d3f6
bootstrap and compiletest: Use size_of_val from the prelude instead o…
thaliaarchi Mar 5, 2025
181ef54
Use final path segment for diagnostic
compiler-errors Mar 5, 2025
571f95f
Remember silenced bootstrap changelog warnings even in --dry-run
moxian Mar 6, 2025
fde3733
`librustdoc`: flatten nested ifs
yotamofek Mar 6, 2025
e13af7a
Don't even bother checking changelog in --dry-run mode
moxian Mar 6, 2025
ca64815
Revert "rustc_middle: parallel: TyCtxt: remove "unsafe impl DynSend/D…
lqd Mar 6, 2025
ad45962
`apply_closure_requirement` use `LocalDefId`
lcnr Mar 6, 2025
7d6bbe2
expand comments of `TyCtxt` impl of `DynSync`/`DynSend`
lqd Mar 6, 2025
71d688b
`TypeVerifier` do not walk into required consts
lcnr Mar 6, 2025
d4c0c94
Stabilize `const_copy_from_slice` feature
okaneco Mar 6, 2025
1fac14d
fix typo
lcnr Mar 6, 2025
662d735
Git ignore citool's target directory
ehuss Mar 6, 2025
6b14125
Fix broken link to Miri intrinsics in documentation
reddevilmidzy Mar 6, 2025
feae279
[llvm/PassWrapper] use `size_t` when building arg strings
cuviper Mar 6, 2025
5143638
Mention me (WaffleLapkin) when changes to `rustc_codegen_ssa` occur
WaffleLapkin Mar 6, 2025
432e1c3
Add the yield_expr feature
eholk Mar 6, 2025
234a68f
Rollup merge of #137827 - yaahc:timestamp-metrics, r=estebank
compiler-errors Mar 6, 2025
65b5a23
Rollup merge of #138041 - thaliaarchi:use-prelude-size-of.boostrap-co…
compiler-errors Mar 6, 2025
3ce0614
Rollup merge of #138046 - onur-ozkan:trim-include-str, r=jieyouxu
compiler-errors Mar 6, 2025
b16f1ac
Rollup merge of #138053 - Kobzol:more-try-jobs, r=marcoieni
compiler-errors Mar 6, 2025
5804b52
Rollup merge of #138061 - jieyouxu:target-reviewers, r=wesleywiser
compiler-errors Mar 6, 2025
3f4c31c
Rollup merge of #138064 - SergioGasquez:feat/xtensa-names, r=jieyouxu
compiler-errors Mar 6, 2025
d36961f
Rollup merge of #138075 - compiler-errors:final-seg, r=Noratrieb
compiler-errors Mar 6, 2025
6963d74
Rollup merge of #138078 - moxian:rember-warns, r=Kobzol
compiler-errors Mar 6, 2025
bc45cdb
Rollup merge of #138081 - eholk:yield-feature, r=oli-obk
compiler-errors Mar 6, 2025
184c2b0
Rollup merge of #138090 - yotamofek:pr/rustdoc/flatten-ifs, r=Guillau…
compiler-errors Mar 6, 2025
efd22c2
Rollup merge of #138092 - lqd:revert-136731, r=SparrowLii
compiler-errors Mar 6, 2025
9452a57
Rollup merge of #138094 - lcnr:cleanup-borrowck, r=fee1-dead
compiler-errors Mar 6, 2025
33985ce
Rollup merge of #138098 - okaneco:stabilize_const_copy_from_slice, r=…
compiler-errors Mar 6, 2025
963b226
Rollup merge of #138103 - ehuss:citool-target, r=Kobzol
compiler-errors Mar 6, 2025
61aaec7
Rollup merge of #138105 - reddevilmidzy:fix-broken-link, r=saethlin
compiler-errors Mar 6, 2025
9891f55
Rollup merge of #138108 - WaffleLapkin:rustc_codegen_ssa_mentions, r=…
compiler-errors Mar 6, 2025
e6d1856
Rollup merge of #138117 - cuviper:passwrapper-size_t, r=Urgau
compiler-errors Mar 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't even bother checking changelog in --dry-run mode
  • Loading branch information
moxian committed Mar 6, 2025
commit e13af7abca71ec6aac4c2115c9563663b83c88cf
12 changes: 6 additions & 6 deletions src/bootstrap/src/bin/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,12 @@ fn main() {
}

// check_version warnings are not printed during setup, or during CI
let changelog_suggestion = if matches!(config.cmd, Subcommand::Setup { .. }) || CiEnv::is_ci() {
None
} else {
check_version(&config)
};
let changelog_suggestion =
if matches!(config.cmd, Subcommand::Setup { .. }) || CiEnv::is_ci() || config.dry_run() {
None
} else {
check_version(&config)
};

// NOTE: Since `./configure` generates a `config.toml`, distro maintainers will see the
// changelog warning, not the `x.py setup` message.
Expand Down Expand Up @@ -188,7 +189,6 @@ fn check_version(config: &Config) -> Option<String> {
));

if io::stdout().is_terminal() {
t!(std::fs::create_dir_all(warned_id_path.parent().unwrap()));
t!(fs::write(warned_id_path, latest_change_id.to_string()));
}
} else {
Expand Down
Loading