Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use as_chunks in analyze_source_file_sse2 #137360

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

real-eren
Copy link
Contributor

Follow-up to #136460. Uses a slightly cleaner method of iterating over chunks of bytes.

@rustbot
Copy link
Collaborator

rustbot commented Feb 21, 2025

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 21, 2025
@real-eren real-eren force-pushed the rustc_span/use-chunks-exact branch from 8d4907e to 7058609 Compare February 23, 2025 03:02
@real-eren real-eren changed the title Use chunks_exact in analyze_source_file_sse2 Use as_chunks in analyze_source_file_sse2 Feb 23, 2025
@bors
Copy link
Contributor

bors commented Feb 23, 2025

☔ The latest upstream changes (presumably #137237) made this pull request unmergeable. Please resolve the merge conflicts.

@real-eren real-eren force-pushed the rustc_span/use-chunks-exact branch from 7058609 to 62f5a55 Compare February 23, 2025 19:04
@Noratrieb
Copy link
Member

cool!
@bors r+

@bors
Copy link
Contributor

bors commented Feb 23, 2025

📌 Commit 62f5a55 has been approved by Noratrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2025
fmease added a commit to fmease/rust that referenced this pull request Feb 25, 2025
…act, r=Noratrieb

Use `as_chunks` in `analyze_source_file_sse2`

Follow-up to rust-lang#136460. Uses a slightly cleaner method of iterating over chunks of bytes.
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 25, 2025
Rollup of 6 pull requests

Successful merges:

 - rust-lang#135480 (Don't require method impls for methods with `Self:Sized` bounds for impls for unsized types)
 - rust-lang#137360 (Use `as_chunks` in `analyze_source_file_sse2`)
 - rust-lang#137460 (downgrade bootstrap `cc`)
 - rust-lang#137515 (Update `compiler-builtins` to 0.1.148)
 - rust-lang#137522 (use stage 2 on cargo and clippy tests when possible)
 - rust-lang#137597 (Revert accidental cargo submodule update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit da31d84 into rust-lang:master Feb 25, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Feb 25, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 25, 2025
Rollup merge of rust-lang#137360 - real-eren:rustc_span/use-chunks-exact, r=Noratrieb

Use `as_chunks` in `analyze_source_file_sse2`

Follow-up to rust-lang#136460. Uses a slightly cleaner method of iterating over chunks of bytes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants