Use const_error! when possible

[thaliaarchi]

Replace usages of io::Error::new(io::ErrorKind::Variant, "constant string") with io::const_error!(io::ErrorKind::Variant, "constant string") to avoid allocations when possible. Additionally, fix &&str error messages in SGX and missing/misplaced trailing commas in const_error!.

[rustbot]

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[thaliaarchi]

I have checked a target for each of the platforms modified:

x check library/std --target=x86_64-unknown-hermit
x check library/std --target=aarch64-kmc-solid_asp3
x check library/std --target=aarch64-unknown-teeos
x check library/std --target=x86_64-unknown-uefi
x check library/std --target=x86_64-unknown-linux-gnu
x check library/std --target=wasm32-wasip1
x check library/std --target=x86_64-pc-windows-gnu
x check library/std --target=riscv32imac-unknown-xous-elf
x check library/test

Note that TEEOS currently fails to build. I fixed that separately in #136769 commit Fix unsafe_op_in_unsafe_fn for TEEOS.

[ChrisDenton]

Thanks!

[ChrisDenton]

@bors r+ rollup

[bors]

📌 Commit 9e390b2 has been approved by ChrisDenton

It is now in the queue for this repository.