Skip to content

Implementation of push_mut #135975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Implementation of push_mut #135975

wants to merge 6 commits into from
+77 −1

Conversation

balt-dev
Copy link

Implementation of #135974.

@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2025

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ibraheemdev (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 24, 2025
@balt-dev balt-dev mentioned this pull request Jan 24, 2025
Open
3 tasks
@balt-dev
Copy link
Author

Sorry if I did this wrong, it's my first time!

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@balt-dev
Copy link
Author

A single trailing whitespace. Oops.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ibraheemdev
Copy link
Member

I'm not sure we should be touching Vec::push here.. maybe just duplicate the implementation?

@balt-dev
Copy link
Author

Alright, I'll do that soon.

@ibraheemdev ibraheemdev added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2025
@balt-dev
Copy link
Author

I finally got around to duplicating the implementation. College has been eating my time like a child with Halloween candy, sorry.

@balt-dev
Copy link
Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 22, 2025
ibraheemdev
ibraheemdev requested changes Feb 23, 2025
View reviewed changes
library/alloc/src/vec/mod.rs
/// Takes *O*(1) time.
#[inline]
#[unstable(feature = "push_mut", issue = "135974")]
// #[unstable(feature = "vec_push_within_capacity", issue = "100486")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this comment be removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, both features apply, so I wasn't quite sure what to do. If push_mut is stabilized before vec_push_within_capacity, this should still be unstable, and same for the reverse.

library/alloc/src/vec/mod.rs
///
/// let mut vec = vec![];
/// // Due to current borrow checker limitations (see -Zpolonius), this is the only way to spell this right now.
/// let last = if let Some(v) = vec.last_mut() { v } else { vec.push_mut(0) };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the point of this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should probably be a better example, yeah. Will update soon!

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2025
@alex-semenyuk
Copy link
Member

@balt-dev
Thanks for your contribution
From wg-triage. Any updates on this PR?

@balt-dev
Copy link
Author

balt-dev commented Apr 7, 2025

I'm sorry, college has been quite a time sink for me and I haven't had the time to follow up as of recent - I will when I can, promise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibraheemdev ibraheemdev ibraheemdev requested changes

Assignees

@ibraheemdev ibraheemdev

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@balt-dev @rustbot @rust-log-analyzer @ibraheemdev @alex-semenyuk