Skip to content

Rollup of 9 pull requests #135202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 7, 2025
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
7f31b57
Replace the random substring of a linker argument with a placeholder …
xingxue-ibm Jan 6, 2025
fc32dd4
llvm: Ignore error value that is always false
maurer Jan 7, 2025
ad5f912
Transmute from NonNull to pointer when elaborating a box deref (MCP807)
scottmcm Nov 15, 2024
53a5857
bootstrap: Build jemalloc for AArch64 with support for 64K pages
mrkajetanp Jan 3, 2025
614dc1c
apply a workaround fix for the release blocker issue
onur-ozkan Jan 7, 2025
7012328
Remove workaround from pull request template
Urgau Jan 7, 2025
b0324cc
don't bless `proc_macro_deps.rs` unless it's necessary
onur-ozkan Jan 7, 2025
7cc99a8
Eliminate an unnecessary `Symbol::to_string`; use `as_str`
joshtriplett Jan 7, 2025
bb6bbfa
Avoid naming variables `str`
joshtriplett Jan 7, 2025
2b97db2
Rollup merge of #135081 - mrkajetanp:jemalloc-64k, r=Kobzol
GuillaumeGomez Jan 7, 2025
2338e57
Rollup merge of #135174 - xingxue-ibm:reproducible-build-aix, r=jieyouxu
GuillaumeGomez Jan 7, 2025
020d875
Rollup merge of #135177 - maurer:rename-module, r=nikic
GuillaumeGomez Jan 7, 2025
a33da79
Rollup merge of #135182 - scottmcm:box-deref-via-transmute, r=oli-obk
GuillaumeGomez Jan 7, 2025
2598d60
Rollup merge of #135187 - onur-ozkan:release-fix, r=pietroalbini
GuillaumeGomez Jan 7, 2025
ebf2e51
Rollup merge of #135189 - Urgau:triagebot-html-ignored, r=lqd
GuillaumeGomez Jan 7, 2025
ccaa0f3
Rollup merge of #135193 - onur-ozkan:tidy-cache-invalidation, r=jieyouxu
GuillaumeGomez Jan 7, 2025
ec26620
Rollup merge of #135198 - joshtriplett:str-is-a-type, r=jieyouxu
GuillaumeGomez Jan 7, 2025
225ffeb
Rollup merge of #135199 - joshtriplett:unnecessary-to-string, r=lqd
GuillaumeGomez Jan 7, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
apply a workaround fix for the release blocker issue
Signed-off-by: onur-ozkan <work@onurozkan.dev>
  • Loading branch information
onur-ozkan committed Jan 7, 2025
commit 614dc1c933c0fc4cf007715857f9951a39c72b86
13 changes: 12 additions & 1 deletion src/build_helper/src/git.rs
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,19 @@ pub fn get_closest_merge_commit(
git.current_dir(git_dir);
}

let channel = include_str!("../../ci/channel");

let merge_base = {
if CiEnv::is_ci() {
if CiEnv::is_ci() &&
// FIXME: When running on rust-lang managed CI and it's not a nightly build,
// `git_upstream_merge_base` fails with an error message similar to this:
// ```
// called `Result::unwrap()` on an `Err` value: "command did not execute successfully:
// cd \"/checkout\" && \"git\" \"merge-base\" \"origin/master\" \"HEAD\"\nexpected success, got: exit status: 1\n"
// ```
// Investigate and resolve this issue instead of skipping it like this.
(channel == "nightly" || !CiEnv::is_rust_lang_managed_ci_job())
{
git_upstream_merge_base(config, git_dir).unwrap()
} else {
// For non-CI environments, ignore rust-lang/rust upstream as it usually gets
Expand Down
Loading