feat: add with_replaced_extension as a alias of with_extension #134676
+29
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Path::with_replaced_extension
that is exactly same asPath::with_extension
but with proper name.This PR implements some portion of my suggestion about
path_add_extension
feature since one positive reaction are received.#127292 (comment)
Currently, this new function is under
path_add_extension
feature but it might be better to move under another feature.Should I split feature flag?
After thinking a while since I suggested, I think
PathBuf::set_extension
is not as ambiguous asPath::with_extension
so I don't added here.However not adding
replace_extension
would be a little inconsistent so there is possibility to be better to addPathBuf::replace_extension
.I want to ask for community and library team.
Relates to
path_add_extension
feature which is tracked in #127292