Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document s390x-unknown-linux targets #133186

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

uweigand
Copy link
Contributor

This adds documentation for the following existing targets:
s390x-unknown-linux-gnu (Tier 2 with host tools)
s390x-unknown-linux-musl (Tier 3)

I volunteer as maintainer for these targets going forward.

This adds documentation for the following existing targets:
  s390x-unknown-linux-gnu (Tier 2 with host tools)
  s390x-unknown-linux-musl (Tier 3)

I volunteer as maintainer for these targets going forward.

Signed-off-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>
@rustbot
Copy link
Collaborator

rustbot commented Nov 18, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 18, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 18, 2024

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@ehuss
Copy link
Contributor

ehuss commented Nov 18, 2024

@wesleywiser or @davidtwco, is there any process for adding new maintainers? Just add anyone that volunteers?

cc @cuviper since I've seen you touch s390 stuff before.

@uweigand
Copy link
Contributor Author

@wesleywiser or @davidtwco, is there any process for adding new maintainers? Just add anyone that volunteers?

Well, that's what I was told to do here: #113739 (comment) ... If there's any other process, I'd be happy to follow that as well.

As additional context, I did actually write most of the initial s390x support code back in the day: #36369; I'm also the LLVM back-end code owner for the platform.

@cuviper
Copy link
Member

cuviper commented Nov 18, 2024

I'm interested in the GNU target insofar as it's relevant to Fedora and RHEL, and I can be an additional contact if needed, but @uweigand is definitely the better expert on this architecture.

@uweigand
Copy link
Contributor Author

I'm interested in the GNU target insofar as it's relevant to Fedora and RHEL, and I can be an additional contact if needed, but @uweigand is definitely the better expert on this architecture.

Hi @cuviper, of course I'd be happy to add you to the list if you volunteer!

@wesleywiser
Copy link
Member

@ehuss if there are existing target maintainers, we cc them on proposed new maintainers and see what they think. In this case, since there's no existing official target maintainers, the main thing we just look at is contribution history. I see @uweigand has a long history of supporting this target so this all looks good to me.

Happy to r+ when the question of adding @cuviper as another maintainer is settled!

Co-authored-by: Josh Stone <cuviper@gmail.com>
Copy link
Member

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Yeah I left the two additional criteria implicit since they felt obviously fulfilled in this case. The null set is very welcoming and the maintainer obviously has the background and commitment.

@wesleywiser
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 18, 2024

📌 Commit 3ae8036 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 19, 2024
Rollup of 9 pull requests

Successful merges:

 - rust-lang#132758 (Improve `{BTreeMap,HashMap}::get_key_value` docs.)
 - rust-lang#133180 ([rustdoc] Fix items with generics not having their jump to def link generated)
 - rust-lang#133181 (Update books)
 - rust-lang#133182 (const_panic: inline in bootstrap builds to avoid f16/f128 crashes)
 - rust-lang#133185 (rustdoc-search: use smart binary search in bitmaps)
 - rust-lang#133186 (Document s390x-unknown-linux targets)
 - rust-lang#133187 (Add reference annotations for diagnostic attributes)
 - rust-lang#133191 (rustdoc book: Move `--test-builder(--wrapper)?` docs to unstable section.)
 - rust-lang#133192 (RELEASES.md: Don't document unstable `--test-build-wrapper`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 49ca6c6 into rust-lang:master Nov 19, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 19, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 19, 2024
Rollup merge of rust-lang#133186 - uweigand:s390x-maintainer, r=wesleywiser

Document s390x-unknown-linux targets

This adds documentation for the following existing targets:
  s390x-unknown-linux-gnu (Tier 2 with host tools)
  s390x-unknown-linux-musl (Tier 3)

I volunteer as maintainer for these targets going forward.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants