-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document s390x-unknown-linux targets #133186
Conversation
This adds documentation for the following existing targets: s390x-unknown-linux-gnu (Tier 2 with host tools) s390x-unknown-linux-musl (Tier 3) I volunteer as maintainer for these targets going forward. Signed-off-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
@wesleywiser or @davidtwco, is there any process for adding new maintainers? Just add anyone that volunteers? cc @cuviper since I've seen you touch s390 stuff before. |
Well, that's what I was told to do here: #113739 (comment) ... If there's any other process, I'd be happy to follow that as well. As additional context, I did actually write most of the initial s390x support code back in the day: #36369; I'm also the LLVM back-end code owner for the platform. |
I'm interested in the GNU target insofar as it's relevant to Fedora and RHEL, and I can be an additional contact if needed, but @uweigand is definitely the better expert on this architecture. |
@ehuss if there are existing target maintainers, we cc them on proposed new maintainers and see what they think. In this case, since there's no existing official target maintainers, the main thing we just look at is contribution history. I see @uweigand has a long history of supporting this target so this all looks good to me. Happy to r+ when the question of adding @cuviper as another maintainer is settled! |
Co-authored-by: Josh Stone <cuviper@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Yeah I left the two additional criteria implicit since they felt obviously fulfilled in this case. The null set is very welcoming and the maintainer obviously has the background and commitment.
@bors r+ rollup |
Rollup of 9 pull requests Successful merges: - rust-lang#132758 (Improve `{BTreeMap,HashMap}::get_key_value` docs.) - rust-lang#133180 ([rustdoc] Fix items with generics not having their jump to def link generated) - rust-lang#133181 (Update books) - rust-lang#133182 (const_panic: inline in bootstrap builds to avoid f16/f128 crashes) - rust-lang#133185 (rustdoc-search: use smart binary search in bitmaps) - rust-lang#133186 (Document s390x-unknown-linux targets) - rust-lang#133187 (Add reference annotations for diagnostic attributes) - rust-lang#133191 (rustdoc book: Move `--test-builder(--wrapper)?` docs to unstable section.) - rust-lang#133192 (RELEASES.md: Don't document unstable `--test-build-wrapper`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#133186 - uweigand:s390x-maintainer, r=wesleywiser Document s390x-unknown-linux targets This adds documentation for the following existing targets: s390x-unknown-linux-gnu (Tier 2 with host tools) s390x-unknown-linux-musl (Tier 3) I volunteer as maintainer for these targets going forward.
This adds documentation for the following existing targets:
s390x-unknown-linux-gnu (Tier 2 with host tools)
s390x-unknown-linux-musl (Tier 3)
I volunteer as maintainer for these targets going forward.