ffi: simplify FromBytesWithNulError in core::c_str
#132731
Open
+10
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`FromBytesWithNulError` is a struct that only contains `kind: FromBytesWithNulErrorKind`, which is an enum. This representation is somewhat redundant. Make `FromBytesWithNulError` an enum that is equivalent to current `FromBytesWithNulErrorKind` in order to simplify. Additionally, add docs for the enum members. Note that this change aligns `FromBytesWithNulError` more closely with `CStrConvertError` in the Linux kernel [1], which will utilize rustc's `CStr` in the future. [1]: https://github.com/Rust-for-Linux/linux/blob/ae7851c29747fa3765ecb722fe722117a346f988/rust/kernel/str.rs#L130-L138
|
r? @Noratrieb rustbot has assigned @Noratrieb. Use |
rustbot
added
S-waiting-on-review
Noratrieb
reviewed
Nov 7, 2024
|
|
||
| #[derive(Clone, PartialEq, Eq, Debug)] | ||
| enum FromBytesWithNulErrorKind { | ||
| pub enum FromBytesWithNulError { |
There was a problem hiding this comment.
this makes the precise enum variants part of the public interface, which we don't want. that's why it's a private field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FromBytesWithNulErroris a struct that only containskind: FromBytesWithNulErrorKind, which is an enum. This representation is somewhat redundant.Make
FromBytesWithNulErroran enum that is equivalent to currentFromBytesWithNulErrorKindin order to simplify. Additionally, add docs for the enum members.Note that this change aligns
FromBytesWithNulErrormore closely withCStrConvertErrorin the Linux kernel 1, which will utilize rustc'sCStrin the future.