Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crater 2024 edition #132712

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Crater 2024 edition #132712

wants to merge 14 commits into from
+2,016 −533

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Nov 6, 2024

No description provided.

ehuss and others added 14 commits November 6, 2024 13:45
@ehuss
Edition 2024 crater run
195bb57
@dingxiangfei2009 @ehuss
reduce false positives of tail-expr-drop-order from consumed values
c82dd3a 
take 2

open up coroutines

tweak the wordings

the lint works up until 2021

We were missing one case, for ADTs, which was
causing `Result` to yield incorrect results.

only include field spans with significant types

deduplicate and eliminate field spans

switch to emit spans to impl Drops

Co-authored-by: Niko Matsakis <nikomat@amazon.com>
@dingxiangfei2009 @ehuss
collect drops instead of taking liveness diff
4520f68
@dingxiangfei2009 @ehuss
apply some suggestions and add explantory notes
1301a22
@dingxiangfei2009 @ehuss
small fix on the cache
94790bd
@dingxiangfei2009 @ehuss
let the query recurse through coroutine
a78c1c2
@dingxiangfei2009 @ehuss
new suggestion format with extracted variable name
d1831bf
@dingxiangfei2009 @ehuss
fine-tune the drop span and messages
1c7c23d
@dingxiangfei2009 @ehuss
bugfix on runtime borrows
3978e86
@dingxiangfei2009 @ehuss
tweak message wording
920d632
@dingxiangfei2009 @ehuss
filter out ecosystem types earlier
9d90f66
@dingxiangfei2009 @ehuss
apply suggestions
f85fb2e
@dingxiangfei2009 @ehuss
clippy
1b7f6ac
@dingxiangfei2009 @ehuss
check lint level at session level
3fd8c5a
@ehuss ehuss self-assigned this Nov 6, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2024

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

Some changes occurred in match lowering

cc @Nadrieril

Some changes occurred to the CTFE machinery

cc @rust-lang/wg-const-eval

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in coverage instrumentation.

cc @Zalathar

This PR changes Stable MIR

cc @oli-obk, @celinval, @ouz-a

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 6, 2024
@ehuss
Copy link
Contributor Author

ehuss commented Nov 6, 2024

@bors try

@bors
Copy link
Contributor

bors commented Nov 6, 2024

⌛ Trying commit 3fd8c5a with merge da25749...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 6, 2024
@bors
Auto merge of rust-lang#132712 - ehuss:2024-crater, r=<try>
da25749 
Crater 2024 edition
@bors
Copy link
Contributor

bors commented Nov 6, 2024

☀️ Try build successful - checks-actions
Build commit: da25749 (da25749bf5e6ba5ed862ff361c19afff2a986b2d)

@ehuss
Copy link
Contributor Author

ehuss commented Nov 6, 2024

@craterbot check cap-lints=allow p=5 crates=top-5000

@craterbot
Copy link
Collaborator

👌 Experiment pr-132712 created and queued.
🤖 Automatically detected try build da25749
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2024
celinval
celinval reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For StableMIR, I was wondering if it would be simpler to translate the new StatementKind to Nop for now. Thanks!

compiler/stable_mir/src/mir/body.rs Show resolved Hide resolved
compiler/stable_mir/src/mir/body.rs Show resolved Hide resolved
compiler/stable_mir/src/mir/pretty.rs Show resolved Hide resolved
compiler/stable_mir/src/mir/visit.rs Show resolved Hide resolved
compiler/rustc_smir/src/rustc_smir/convert/mir.rs Show resolved Hide resolved
compiler/rustc_smir/src/rustc_smir/convert/mir.rs Show resolved Hide resolved
@ehuss
Copy link
Contributor Author

ehuss commented Nov 8, 2024

@celinval sorry for the confusion. The changes in this PR are not to be reviewed. It just contains a copy of #131326 for crater testing. If you have feedback, it would be best to leave it over there.

@celinval
Copy link
Contributor

celinval commented Nov 8, 2024

@celinval sorry for the confusion. The changes in this PR are not to be reviewed. It just contains a copy of #131326 for crater testing. If you have feedback, it would be best to leave it over there.

My bad. Not used to the automation yet. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celinval celinval celinval left review comments

Assignees

@ehuss ehuss

Labels
S-waiting-on-crater Status: Waiting on a crater run to be completed. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ehuss @rustbot @bors @craterbot @celinval @dingxiangfei2009