Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document type_implements_trait #132608

Merged
merged 2 commits into from
Nov 5, 2024
Merged

document type_implements_trait #132608

merged 2 commits into from
Nov 5, 2024

Conversation

mejrs
Copy link
Contributor

@mejrs mejrs commented Nov 4, 2024

Rendered:

image

r? @compiler-errors

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 4, 2024
compiler-errors
compiler-errors reviewed Nov 4, 2024
View reviewed changes
compiler/rustc_trait_selection/src/infer.rs Outdated
/// ```
///
/// In most cases you should instead create an [Obligation](traits::Obligation)
/// and check whether it holds, because it properly handles higher ranked traits
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// and check whether it holds, because it properly handles higher ranked traits
/// and check whether it holds via `evaluate_obligation` or one of its helper functions like `predicate_must_hold_modulo_regions`, because it properly handles higher ranked traits

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps

@compiler-errors
Copy link
Member

@rustbot author

please edit this to explain what to do instead, then r=me

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2024
@mejrs
Copy link
Contributor Author

mejrs commented Nov 5, 2024

@rustbot ready

Updated to:
image

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 5, 2024
@compiler-errors
Copy link
Member

thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 5, 2024

📌 Commit e37a3a8 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2024
@workingjubilee workingjubilee mentioned this pull request Nov 5, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 5, 2024
@bors
Auto merge of rust-lang#132626 - workingjubilee:rollup-hbmtbzk, r=wor…
27e38f8 
…kingjubilee

Rollup of 11 pull requests

Successful merges:

 - rust-lang#131153 (Improve duplicate derive Copy/Clone diagnostics)
 - rust-lang#132025 (fix suggestion for diagnostic error E0027)
 - rust-lang#132303 (More tests for non-exhaustive C-like enums in FFI)
 - rust-lang#132492 (remove support for extern-block const intrinsics)
 - rust-lang#132587 (Revert "Avoid nested replacement ranges" from rust-lang#129346.)
 - rust-lang#132596 ([rustdoc] Fix `--show-coverage` when JSON output format is used)
 - rust-lang#132598 (Clippy: Move some attribute lints to be early pass (post expansion))
 - rust-lang#132601 (Update books)
 - rust-lang#132606 (Improve example of `impl Pattern for &[char]`)
 - rust-lang#132608 (document `type_implements_trait`)
 - rust-lang#132609 (docs: fix grammar in doc comment at unix/process.rs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 33ebfff into rust-lang:master Nov 5, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 5, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 5, 2024
@rust-timer
Unrolled build for rust-lang#132608
a215251 
Rollup merge of rust-lang#132608 - mejrs:type_impls_trait, r=compiler-errors

document `type_implements_trait`

Rendered:

![image](https://github.com/user-attachments/assets/60c00e50-24fd-4b04-bb22-e71b479c0b29)

r? `@compiler-errors`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mejrs @compiler-errors @bors @rustbot