compiler: rename LayoutS to LayoutData #132252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last {UninternedType}S is in captivity. The galaxy is at peace.
rustbot
added
S-waiting-on-review
|
Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
jieyouxu
approved these changes
Oct 28, 2024
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 28, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#131391 (Stabilize `isqrt` feature) - rust-lang#132248 (rustc_transmute: Directly use types from rustc_abi) - rust-lang#132252 (compiler: rename LayoutS to LayoutData) - rust-lang#132253 (Known-bug test for `keyword_idents` lint not propagating to other files) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 28, 2024
Rollup merge of rust-lang#132252 - workingjubilee:rename-layouts-to-layoutdata, r=jieyouxu compiler: rename LayoutS to LayoutData Bid `LayoutS` goodbye because it looks like a typo. `LayoutS` is the last of the types that use the "`{TypeName}` is the interned type, `{TypeName}S` is the backing data that is interned" convention. This is pretty confusing to those not intimately familiar with the history of rustc's names for its types over time, and doubly so now that there are no other examples in the tree. Abolish this convention.
|
I will admit I originally thought LayoutS was a typo and pointed it out to jubilee, thanks for the clarification and fixing it for everyone forever :D |
github-merge-queue bot
pushed a commit
to model-checking/kani
that referenced
this pull request
Oct 29, 2024
Culprit PR identified by @tautschnig: rust-lang/rust#132252 Resolves #3657 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bid
LayoutSgoodbye because it looks like a typo.LayoutSis the last of the types that use the "{TypeName}is the interned type,{TypeName}Sis the backing data that is interned" convention. This is pretty confusing to those not intimately familiar with the history of rustc's names for its types over time, and doubly so now that there are no other examples in the tree. Abolish this convention.