Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Hacker's Delight impl in i64::midpoint instead of wide i128 impl #132238

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Use Hacker's Delight impl in i64::midpoint instead of wide i128 impl #132238

merged 1 commit into from
Oct 30, 2024

Commits on Oct 27, 2024

  1. Use Hacker's Delight impl in i64::midpoint instead of wide i128 impl 

    As LLVM seems to be outperformed by the complexity of signed 128-bits
number compared to our Hacker's Delight implementation.[^1]

It doesn't seems like it's an improvement for the other sizes[^2], so we
let them with the wide implementation.

[^1]: https://rust.godbolt.org/z/ravE75EYj
[^2]: https://rust.godbolt.org/z/fzr171zKh
    @Urgau
    Urgau committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    ad80da6 View commit details
    Browse the repository at this point in the history