Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Elaborate drops to calls #130691

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

scottmcm
Copy link
Member

For now just borrowing CI to check for annoying no_core tests that I broke
r? ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 22, 2024
@rust-log-analyzer

This comment has been minimized.

@scottmcm scottmcm force-pushed the elaborate-drops-to-calls branch from 7021e59 to 5c25712 Compare September 22, 2024 07:37
@rust-log-analyzer

This comment has been minimized.

@scottmcm scottmcm force-pushed the elaborate-drops-to-calls branch from 5c25712 to b154623 Compare September 22, 2024 07:55
@scottmcm scottmcm added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2024
@scottmcm
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 22, 2024
@bors
Copy link
Contributor

bors commented Sep 22, 2024

⌛ Trying commit b154623 with merge b8f401a...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2024
…=<try>

[WIP] Elaborate drops to calls

For now just borrowing CI to check for annoying no_core tests that I broke
r? ghost
@bors
Copy link
Contributor

bors commented Sep 22, 2024

☀️ Try build successful - checks-actions
Build commit: b8f401a (b8f401a25404c2949e23ca324e249db46e4aff51)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b8f401a): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.6% [0.2%, 9.0%] 7
Regressions ❌
(secondary)
0.3% [0.1%, 0.9%] 4
Improvements ✅
(primary)
-1.2% [-2.0%, -0.2%] 4
Improvements ✅
(secondary)
-1.1% [-1.7%, -0.2%] 10
All ❌✅ (primary) 0.6% [-2.0%, 9.0%] 11

Max RSS (memory usage)

Results (primary 2.1%, secondary -2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.3% [2.6%, 4.7%] 3
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.4% [-1.4%, -1.4%] 1
Improvements ✅
(secondary)
-2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) 2.1% [-1.4%, 4.7%] 4

Cycles

Results (primary 0.4%, secondary 2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
6.3% [6.3%, 6.3%] 1
Regressions ❌
(secondary)
2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)
-1.1% [-1.7%, -0.6%] 4
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.4% [-1.7%, 6.3%] 5

Binary size

Results (primary -0.7%, secondary -1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.7% [-1.0%, -0.2%] 6
Improvements ✅
(secondary)
-1.0% [-2.0%, -0.1%] 6
All ❌✅ (primary) -0.7% [-1.0%, -0.2%] 6

Bootstrap: 769.195s -> 756.316s (-1.67%)
Artifact size: 341.55 MiB -> 341.49 MiB (-0.02%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants