add llvm-bitcode-linker and llvm-tools bins to ci-rustc's sysroot #130302
+47
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <work@onurozkan.dev>
rustbot
added
S-waiting-on-review
|
We should probably wait for the try build result before landing this. |
|
This is cursed.. :) |
Kobzol
reviewed
Sep 13, 2024
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup=iffy |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 14, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#130138 (bootstrap: Print more debug info when `find_initial_libdir` fails) - rust-lang#130199 (Don't call closure_by_move_body_def_id on FnOnce async closures in MIR validation) - rust-lang#130302 (add llvm-bitcode-linker and llvm-tools bins to ci-rustc's sysroot) - rust-lang#130306 (avoid updating LLVM submodule during bootstrap unit tests) - rust-lang#130317 (`ProjectionElem` and `UnOp`/`BinOp` dont need to be `PartialOrd`/`Ord`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 14, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#130138 (bootstrap: Print more debug info when `find_initial_libdir` fails) - rust-lang#130199 (Don't call closure_by_move_body_def_id on FnOnce async closures in MIR validation) - rust-lang#130302 (add llvm-bitcode-linker and llvm-tools bins to ci-rustc's sysroot) - rust-lang#130306 (avoid updating LLVM submodule during bootstrap unit tests) - rust-lang#130317 (`ProjectionElem` and `UnOp`/`BinOp` dont need to be `PartialOrd`/`Ord`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 14, 2024
Rollup merge of rust-lang#130302 - onur-ozkan:130040-with-fixes, r=Kobzol add llvm-bitcode-linker and llvm-tools bins to ci-rustc's sysroot rust-lang#130040 is [reverted](rust-lang#130292) because adding component binaries directly to the dist tarball of the compiler caused conflicts (see rust-lang#130291 and rust-lang/rustup#4019). This PR solves the original problem without touching the dist tarball. r? Kobzol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#130040 is reverted because adding component binaries directly to the dist tarball of the compiler caused conflicts (see #130291 and rust-lang/rustup#4019). This PR solves the original problem without touching the dist tarball.
r? Kobzol